Merge pull request #89 from github/component-with-content

joelhawksley · web-flow · commit 320115a29dc4 · 2021-06-24T16:41:06.000-06:00
Add support for rendering ViewComponents `with_content`
diff --git a/lib/rubocop/cop/github/render_literal_helpers.rb b/lib/rubocop/cop/github/render_literal_helpers.rb
@@ -20,10 +20,6 @@ module RenderLiteralHelpers
           (send nil? {:render :render_to_string} ({str sym} $_) $...)
         PATTERN
 
-        def_node_matcher :render_inst?, <<-PATTERN
-          (send nil? {:render :render_to_string} (send _ :new ...) ...)
-        PATTERN
-
         def_node_matcher :render_with_options?, <<-PATTERN
           (send nil? {:render :render_to_string} (hash $...) ...)
         PATTERN
@@ -32,6 +28,10 @@ module RenderLiteralHelpers
           (send nil? {:render :render_to_string} (send _ :new ...) ...)
         PATTERN
 
+        def_node_matcher :render_view_component_instance_with_content?, <<-PATTERN
+          (send nil? {:render :render_to_string} (send (send _ :new ...) `:with_content ...))
+        PATTERN
+
         def_node_matcher :render_view_component_collection?, <<-PATTERN
           (send nil? {:render :render_to_string} (send _ :with_collection ...) ...)
         PATTERN
@@ -45,7 +45,8 @@ def hash_with_literal_keys?(hash)
         end
 
         def render_view_component?(node)
-          render_view_component_instance?(node) ||
+          render_view_component_instance_with_content?(node) ||
+            render_view_component_instance?(node) ||
             render_view_component_collection?(node)
         end
       end
diff --git a/test/test_rails_view_render_literal.rb b/test/test_rails_view_render_literal.rb
@@ -62,6 +62,14 @@ def test_render_component_instance_no_offense
     assert_equal 0, cop.offenses.count
   end
 
+  def test_render_component_instance_with_content_no_offense
+    erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
+      <%= render MyClass.new(title: "foo", bar: "baz").with_content("foo") %>
+    ERB
+
+    assert_equal 0, cop.offenses.count
+  end
+
   def test_render_component_instance_block_no_offense
     erb_investigate cop, <<-ERB, "app/views/foo/index.html.erb"
       <%= render Module::MyClass.new(title: "foo", bar: "baz") do %>Content<% end %>
