config/default: Explicitly set Enabled: false for a bunch of rules

issyl0 · web-flow · commit f40758f26ce5 · 2022-10-11T17:31:07.000Z
- These rules come directly from RuboCop. They're configured `Enabled: false`
  upstream, but it's worth being explicit in this gem since this guards
  against RuboCop changing underneath us and causing linting changes that
  either don't match our styleguide or we don't want to propagate to
  users of this gem.
- This was generated by the following script (thanks to `@matthewd`),
  where `show-cops.yml` is the output of
  `bundle exec rubocop --show-cops`:

```ruby
require "yaml"
y = YAML.unsafe_load_file("show-cops.yml")
cfg = YAML.unsafe_load_file(".rubocop.yml")
off = y.keys.select { |k| y[k]["Enabled"] == false }
(off - cfg.keys).sort.each { |k| puts "#{k}:\n  Enabled: false\n\n" }
```

- Next I'll do the same for `Enabled: true`, then in a follow-up commit
  or PR (probably PR, at this point) I'll go through and link the
  `Enabled: true` ones to their styleguide items in the GitHub styleguide.
diff --git a/config/default.yml b/config/default.yml
@@ -5,9 +5,18 @@ require:
 Bundler/DuplicatedGem:
   Enabled: true
 
+Bundler/GemComment:
+  Enabled: false
+
+Bundler/GemVersion:
+  Enabled: false
+
 Bundler/OrderedGems:
   Enabled: true
 
+Gemspec/DependencyVersion:
+  Enabled: false
+
 GitHub/InsecureHashAlgorithm:
   Enabled: true
 
@@ -17,18 +26,39 @@ Layout/BlockAlignment:
 Layout/BlockEndNewline:
   Enabled: true
 
+Layout/ClassStructure:
+  Enabled: false
+
 Layout/ConditionPosition:
   Enabled: true
 
 Layout/DefEndAlignment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
+
 Layout/EndAlignment:
   Enabled: false
 
 Layout/EndOfLine:
   Enabled: true
 
+Layout/FirstArrayElementLineBreak:
+  Enabled: false
+
+Layout/FirstHashElementLineBreak:
+  Enabled: false
+
+Layout/FirstMethodArgumentLineBreak:
+  Enabled: false
+
+Layout/FirstMethodParameterLineBreak:
+  Enabled: false
+
+Layout/HeredocArgumentClosingParenthesis:
+  Enabled: false
+
 Layout/IndentationStyle:
   Enabled: true
   EnforcedStyle: spaces
@@ -44,6 +74,24 @@ Layout/InitialIndentation:
 Layout/LineLength:
   Enabled: false
 
+Layout/MultilineArrayLineBreaks:
+  Enabled: false
+
+Layout/MultilineAssignmentLayout:
+  Enabled: false
+
+Layout/MultilineHashKeyLineBreaks:
+  Enabled: false
+
+Layout/MultilineMethodArgumentLineBreaks:
+  Enabled: false
+
+Layout/RedundantLineBreak:
+  Enabled: false
+
+Layout/SingleLineBlockChain:
+  Enabled: false
+
 Layout/SpaceAfterColon:
   Enabled: true
 
@@ -96,6 +144,9 @@ Layout/TrailingWhitespace:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantResolution:
+  Enabled: false
+
 Lint/Debugger:
   Enabled: true
 
@@ -132,6 +183,9 @@ Lint/FloatOutOfRange:
 Lint/FormatParameterMismatch:
   Enabled: true
 
+Lint/HeredocMethodCallPosition:
+  Enabled: false
+
 Lint/LiteralAsCondition:
   Enabled: true
 
@@ -144,6 +198,9 @@ Lint/Loop:
 Lint/NextWithoutAccumulator:
   Enabled: true
 
+Lint/NumberConversion:
+  Enabled: false
+
 Lint/RandOne:
   Enabled: true
 
@@ -213,12 +270,21 @@ Naming/ClassAndModuleCamelCase:
 Naming/FileName:
   Enabled: true
 
+Naming/InclusiveLanguage:
+  Enabled: false
+
 Naming/MethodName:
   Enabled: true
 
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: false
+
 Performance/CaseWhenSplat:
   Enabled: false
 
+Performance/ChainArrayAllocation:
+  Enabled: false
+
 Performance/Count:
   Enabled: true
 
@@ -234,6 +300,9 @@ Performance/EndWith:
 Performance/FlatMap:
   Enabled: true
 
+Performance/OpenStruct:
+  Enabled: false
+
 Performance/RangeInclude:
   Enabled: false
 
@@ -247,6 +316,9 @@ Performance/RedundantMerge:
 Performance/ReverseEach:
   Enabled: true
 
+Performance/SelectMap:
+  Enabled: false
+
 Performance/Size:
   Enabled: true
 
@@ -256,9 +328,18 @@ Performance/StartWith:
 Security/Eval:
   Enabled: true
 
+Style/ArrayCoercion:
+  Enabled: false
+
 Style/ArrayJoin:
   Enabled: true
 
+Style/AsciiComments:
+  Enabled: false
+
+Style/AutoResourceCleanup:
+  Enabled: false
+
 Style/BeginBlock:
   Enabled: true
 
@@ -274,12 +355,33 @@ Style/CharacterLiteral:
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+
+Style/CollectionMethods:
+  Enabled: false
+
+Style/ConstantVisibility:
+  Enabled: false
+
 Style/Copyright:
   Enabled: false
 
+Style/DateTime:
+  Enabled: false
+
 Style/DefWithParentheses:
   Enabled: true
 
+Style/DisableCopsWithinSourceCodeDirective:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DocumentationMethod:
+  Enabled: false
+
 Style/EndBlock:
   Enabled: true
 
@@ -289,22 +391,40 @@ Style/For:
 Style/FrozenStringLiteralComment:
   Enabled: true
 
+Style/ImplicitRuntimeError:
+  Enabled: false
+
+Style/InlineComment:
+  Enabled: false
+
+Style/IpAddresses:
+  Enabled: false
+
 Style/HashSyntax:
   Enabled: true
   EnforcedStyle: ruby19_no_mixed_keys
 
 Style/LambdaCall:
   Enabled: true
 
+Style/MethodCalledOnDoEndBlock:
+  Enabled: false
+
 Style/MethodCallWithoutArgsParentheses:
   Enabled: true
 
 Style/MethodDefParentheses:
   Enabled: true
 
+Style/MissingElse:
+  Enabled: false
+
 Style/MultilineIfThen:
   Enabled: true
 
+Style/MultilineMethodSignature:
+  Enabled: false
+
 Style/NilComparison:
   Enabled: true
 
@@ -314,18 +434,45 @@ Style/Not:
 Style/OneLineConditional:
   Enabled: true
 
+Style/OptionHash:
+  Enabled: false
+
 Style/RedundantSortBy:
   Enabled: true
 
+Style/ReturnNil:
+  Enabled: false
+
 Style/Sample:
   Enabled: true
 
+Style/SingleLineBlockParams:
+  Enabled: false
+
 Style/StabbyLambdaParentheses:
   Enabled: true
 
+Style/StaticClass:
+  Enabled: false
+
 Style/Strip:
   Enabled: true
 
+Style/StringHashKeys:
+  Enabled: false
+
 Style/StringLiterals:
   Enabled: true
   EnforcedStyle: double_quotes
+
+Style/StringMethods:
+  Enabled: false
+
+Style/TopLevelMethodDefinition:
+  Enabled: false
+
+Style/TrailingCommaInBlockArgs:
+  Enabled: false
+
+Style/UnlessLogicalOperators:
+  Enabled: false
