Avoid unnecessary writes to ISEQ during GC

jhawthorn · jhawthorn · commit 1a6b13dab428 · 2024-07-09T10:25:38.000-07:00
On mark we check whether a callcache has been invalidated and if it has
we replace it with the empty callcache, rb_vm_empty_cc(). However we
also consider the empty callcache to not be active, and so previously
would overwrite it with itself.

These additional writes are problematic because they may force
Copy-on-Write to occur on the memory page, increasing system memory use.
diff --git a/iseq.c b/iseq.c
@@ -344,7 +344,7 @@ rb_iseq_mark_and_move(rb_iseq_t *iseq, bool reference_updating)
                 if (cc_is_active(cds[i].cc, reference_updating)) {
                     rb_gc_mark_and_move_ptr(&cds[i].cc);
                 }
-                else {
+                else if (cds[i].cc != rb_vm_empty_cc()) {
                     cds[i].cc = rb_vm_empty_cc();
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -344,7 +344,7 @@ rb_iseq_mark_and_move(rb_iseq_t *iseq, bool reference_updating)`
`344`	`344`	`if (cc_is_active(cds[i].cc, reference_updating)) {`
`345`	`345`	`rb_gc_mark_and_move_ptr(&cds[i].cc);`
`346`	`346`	`}`
`347`		`- else {`
	`347`	`+ else if (cds[i].cc != rb_vm_empty_cc()) {`
`348`	`348`	`cds[i].cc = rb_vm_empty_cc();`
`349`	`349`	`}`
`350`	`350`	`}`