* hash.c (ruby_setenv): MSDN says that Windows XP or earlier limits

unak · unak · commit 45f59656ae27 · 2011-03-08T07:52:19.000Z
the total size of environment block to 5,120 chars.  and on such
  OS, putenv() causes SEGV.  So, ruby should limit the size of an
  environment variable to 5,120 bytes for workaround.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@31063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,10 @@
+Tue Mar  8 16:45:31 2011  NAKAMURA Usaku  <usa@ruby-lang.org>
+
+	* hash.c (ruby_setenv): MSDN says that Windows XP or earlier limits
+	  the total size of environment block to 5,120 chars.  and on such
+	  OS, putenv() causes SEGV.  So, ruby should limit the size of an
+	  environment variable to 5,120 bytes for workaround.
+
 Tue Mar  8 15:57:20 2011  NAKAMURA Usaku  <usa@ruby-lang.org>
 
 	* test/rubygems/test_gem_spec_fetcher.rb
diff --git a/hash.c b/hash.c
@@ -2206,6 +2206,7 @@ ruby_setenv(const char *name, const char *value)
 	rb_sys_fail("ruby_setenv");
     }
     if (value) {
+	if (strlen(value) > 5120) goto fail;
 	buf = rb_sprintf("%s=%s", name, value);
     }
     else {

Original file line number	Diff line number	Diff line change
`@@ -2206,6 +2206,7 @@ ruby_setenv(const char name, const char value)`
`2206`	`2206`	`rb_sys_fail("ruby_setenv");`
`2207`	`2207`	`}`
`2208`	`2208`	`if (value) {`
	`2209`	`+ if (strlen(value) > 5120) goto fail;`
`2209`	`2210`	`buf = rb_sprintf("%s=%s", name, value);`
`2210`	`2211`	`}`
`2211`	`2212`	`else {`