Fix RUBY_FREE_AT_EXIT with ASAN

peterzhu2118 · peterzhu2118 · commit c480dec1ccf3 · 2024-07-04T09:25:50.000-04:00
When Ruby is built with ASAN and RUBY_FREE_AT_EXIT is enabled, the following error occurs: READ of size 8 at 0x74c666610020 thread T0 #0 0x593b6712ecc6 in RB_BUILTIN_TYPE include/ruby/internal/value_type.h:191:30 #1 0x593b6712ecc6 in rb_gc_impl_shutdown_free_objects gc_impl.c:3208:17 #2 0x593b6749a62e in ruby_vm_destruct vm.c:3133:17
diff --git a/gc_impl.c b/gc_impl.c
@@ -3205,8 +3205,10 @@ rb_gc_impl_shutdown_free_objects(void *objspace_ptr)
         uintptr_t pend = p + page->total_slots * stride;
         for (; p < pend; p += stride) {
             VALUE vp = (VALUE)p;
-            if (RB_BUILTIN_TYPE(vp) != T_NONE) {
-                rb_gc_obj_free(objspace, vp);
+            asan_unpoisoning_object(vp) {
+                if (RB_BUILTIN_TYPE(vp) != T_NONE) {
+                    rb_gc_obj_free(objspace, vp);
+                }
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -3205,8 +3205,10 @@ rb_gc_impl_shutdown_free_objects(void *objspace_ptr)`
`3205`	`3205`	`uintptr_t pend = p + page->total_slots * stride;`
`3206`	`3206`	`for (; p < pend; p += stride) {`
`3207`	`3207`	`VALUE vp = (VALUE)p;`
`3208`		`- if (RB_BUILTIN_TYPE(vp) != T_NONE) {`
`3209`		`- rb_gc_obj_free(objspace, vp);`
	`3208`	`+ asan_unpoisoning_object(vp) {`
	`3209`	`+ if (RB_BUILTIN_TYPE(vp) != T_NONE) {`
	`3210`	`+ rb_gc_obj_free(objspace, vp);`
	`3211`	`+ }`
`3210`	`3212`	`}`
`3211`	`3213`	`}`
`3212`	`3214`	`}`