Skip to content

Use octicon as sortable item icon handler icon #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2021
Merged

Use octicon as sortable item icon handler icon #17

merged 3 commits into from
Feb 16, 2021

Conversation

iulia-b
Copy link
Contributor

@iulia-b iulia-b commented Feb 15, 2021

This PR is updating the svg icon used as handler for a task item to a Primer icon
This is part of [Public Beta] Task Lists V2

cc @ohjoycelau for product design decision

Before
image

After
image

@iulia-b iulia-b requested a review from a team as a code owner February 15, 2021 11:59
@iulia-b iulia-b force-pushed the upgrade-grab-handler branch from 56f39bc to 3a4872f Compare February 15, 2021 12:01
koddsson
koddsson approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✨

@iulia-b @koddsson
Update src/task-lists-element.ts
a50a3e1 
Co-authored-by: Kristján Oddsson <koddsson@gmail.com>
@koddsson koddsson merged commit bec11b2 into main Feb 16, 2021
@koddsson koddsson deleted the upgrade-grab-handler branch February 16, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iulia-b @koddsson