Skip to content

Fix Task Lists Element dragability #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2023
Merged

Fix Task Lists Element dragability #38

merged 1 commit into from
Feb 14, 2023

Conversation

KyFaSt
Copy link
Contributor

@KyFaSt KyFaSt commented Feb 13, 2023

We discovered that in the PR #35 creating SVG elements requires createElementNS instead of createElement. This PR replaces createElement with createElementNS and returns the draggable behavior.

Fixes https://github.com/github/primer/issues/1787

@KyFaSt KyFaSt requested a review from a team as a code owner February 13, 2023 21:30
@KyFaSt KyFaSt requested a review from keithamus February 13, 2023 21:32
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • ⏩ If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

keithamus
keithamus approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KyFaSt KyFaSt merged commit 78fff62 into main Feb 14, 2023
@KyFaSt KyFaSt deleted the pse-paved-paths-fix-task-list-drag branch February 14, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyFaSt @primer-css @keithamus