Replace the babel compiler with the typscript compiler #9
Conversation
tsconfig.json
Outdated
| "allowJs": true | ||
| }, | ||
| "files": [ | ||
| "src/textarea-autosize.js" |
There was a problem hiding this comment.
Thanks for moving this to a src/ directory. Many of our repositories don't have one because the code base started out as a single source file. But as modules are added projects we really need a src directory to organize them.
Maybe we could standardize on src/index.js as the entry point as well. I often spend a few seconds stumbling through my editor looking for the main file while bouncing between repositories.
There was a problem hiding this comment.
Maybe we could standardize on
src/index.jsas the entry point as well. I often spend a few seconds stumbling through my editor looking for the main file while bouncing between repositories.
Yeah I think that's fair. Having a src/ directory seems to be a typescript convention that I really like.
textarea-autosize.d.ts
Outdated
| } | ||
|
|
||
| export default function autosize(textarea: HTMLTextAreaElement): Subscription; |
There was a problem hiding this comment.
This file can be deleted now that tsc generates it.
|
Waiting to see how github/remote-input-element#19 shakes out before continuing with this work. |
Co-Authored-By: Keith Cirkel <keithamus@users.noreply.github.com>
Co-Authored-By: Keith Cirkel <keithamus@users.noreply.github.com>
Instead of updating the babel compiler here, we just replace it with the typescript compiler.
Note that this change will fail in CI until we merge github/eslint-plugin-github#78