Skip to content

Can't exclude issues without labels #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spacecowboy opened this issue Oct 27, 2015 · 3 comments
Closed

Can't exclude issues without labels #302

spacecowboy opened this issue Oct 27, 2015 · 3 comments

Comments

@spacecowboy
Copy link

Running with --no-issues-wo-labels seems to make no difference. There is still a Closed issues section generated with issues that have no tags.

@spacecowboy spacecowboy changed the title Can't exclude issues without tags Can't exclude issues without labels Oct 27, 2015
@chros73
Copy link

chros73 commented Jul 18, 2016

I can confirm this issue (using v1.13.0) with --no-issues-wo-labels and the same applies to --no-pr-wo-labels as well (no matter whether --no-filter-by-milestone is set or not).

Sample config:

compare-link=false
issues-wo-labels=false
pr-wo-labels=false
unreleased=true
future-release=1.4-0.9.6
exclude-tags=final-0.8.x-support
since-tag=0.9.4-20150310-46ed5cb

URL to issues: https://github.com/chros73/rtorrent-ps/issues?q=is%3Aissue+is%3Aclosed
Note: There are 3 issues without label and all of them are included (every issue has been assigned to a milestone (there's no issue with multiple label)). Also it doesn't matter whether an issue that hasn't got label is assigned to a milestone or not.

URL to pull requests: https://github.com/chros73/rtorrent-ps/pulls?q=is%3Apr+is%3Aclosed
Note: 2 of them out of 3 is included:

- Update to current head fork [\#7](https://github.com/chros73/rtorrent-ps/pull/7) ([chros73](https://github.com/chros73))
- Merging changes from original master branch [\#6](https://github.com/chros73/rtorrent-ps/pull/6) ([chros73](https://github.com/chros73))

What can be the quick workaround for excluding simple closed issues?

Thanks

Edit: also, since-tag ignores this tag final-0.8.x-support for some reason, hence the hack around it.

@chros73
Copy link

chros73 commented Jul 18, 2016

So, the workaround for these bugs for now can be that we assign a dummy label (e.g. no-changelog) to those issues/pull-requests and use exclude-labels=no-changelog in config.
The working config (with couple of hacks :) ) is:

compare-link=false
#issues-wo-labels=false
#pr-wo-labels=false
exclude-labels=no-changelog
unreleased=true
future-release=1.4-0.9.6
exclude-tags=final-0.8.x-support
since-tag=0.9.4-20150310-46ed5cb

@mvz
Copy link
Contributor

mvz commented Jan 2, 2024

Like #292, this was probably fixed in #618.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants