Skip to content

Docs: update the token failure example to OctoKit 404 failure #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olleolleolle opened this issue Oct 19, 2016 · 3 comments
Open

Docs: update the token failure example to OctoKit 404 failure #435

olleolleolle opened this issue Oct 19, 2016 · 3 comments
Labels
hacktoberfest Enjoy flashmob: https://hacktoberfest.digitalocean.com. Get a swag! help wanted

Comments

@olleolleolle
Copy link
Collaborator

This part of the readme refers to a failure which won't happen with OctoKit:

https://github.com/skywinder/github-changelog-generator/#github-token

@jdel7
Copy link
Contributor

jdel7 commented May 27, 2017

Is this the 404 error that is supposed to show with OctoKit?

API rate limit exceeded for deohtee.
See: https://developer.github.com/v3/#rate-limiting

Want to double check before submitting a PR.

@olleolleolle
Copy link
Collaborator Author

@deohtee Yes, this is the kind of error that we would like to talk about in this part of the README. There may be other outputs, but this communicative error message (including that link about Rate Limiting, suuuuper) guides the user to the right solution quicker.

To be clear, this section is now inaccurate:

So, if you got an error like this:

! /Library/Ruby/Gems/2.0.0/gems/github_api-0.12.2/lib/github_api/response/raise_error.rb:14:in `on_complete'

@skywinder
Copy link
Member

Related to #482

@skywinder skywinder added in progress hacktoberfest Enjoy flashmob: https://hacktoberfest.digitalocean.com. Get a swag! labels Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Enjoy flashmob: https://hacktoberfest.digitalocean.com. Get a swag! help wanted
Projects
None yet
Development

No branches or pull requests

4 participants