Skip to content

Depending on time of changelog creation the date of old changelog entries changes #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
akleiber opened this issue Apr 10, 2017 · 1 comment
Open

Depending on time of changelog creation the date of old changelog entries changes #491

akleiber opened this issue Apr 10, 2017 · 1 comment

Comments

@akleiber
Copy link

Maybe this is not related to github-changelog-generator may be it is.

I have a closed pull request that was closed and merged on 08.04.2017 23:23 MESZ (UTC+2) according to GitHub. I created the changelog on 09.04.2017 00:05 MESZ (UTC+2). The release got the release date of 09.04.2017. Let's name this release R-1.

When I create a changelog for new releases the date for release R-1 changes to 08.04.2017 depending on the time I create the changelog.

According to GitHub the commits API returns dates with timeformat: https://developer.github.com/v3/#timezones

I am not a ruby user so I have no clue if we need to specify a timezone for strftime in https://github.com/skywinder/github-changelog-generator/blob/master/lib/github_changelog_generator/generator/generator_generation.rb#L56
@olleolleolle
Copy link
Collaborator

strftime's date format is a configuration options

        opts.on("-f", "--date-format [FORMAT]", "Date format. Default is %Y-%m-%d") do |last|
          options[:date_format] = last
        end

@unicolet unicolet mentioned this issue May 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olleolleolle @akleiber