Skip to content

bug: Output on aborting when unknown user and project only prints out banner, not why it aborted #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Furtif opened this issue Oct 15, 2017 · 12 comments
Closed

bug: Output on aborting when unknown user and project only prints out banner, not why it aborted #577

Furtif opened this issue Oct 15, 2017 · 12 comments

Comments

@Furtif
Copy link

Furtif commented Oct 15, 2017

Use bundle info [gemname] to see where a bundled gem is installed.
bundle exec github_changelog_generator
Usage: github_changelog_generator [options]
Command exited with code 1
@olleolleolle
Copy link
Collaborator

I’m not quite following.

Can you explain this with words like “I’m trying to achieve ___” or “When I do ___ this happens ___ but I expected ___.”

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017 •
edited
Loading

appveyor bug

Switched to a new branch 'Appveyor'
SET PATH=C:\Ruby23-x64\bin;%PATH%
ruby --version
ruby 2.3.3p222 (2016-11-21 revision 56859) [x64-mingw32]
where ruby
C:\Ruby23-x64\bin\ruby.exe
C:\Ruby193\bin\ruby.exe
gem update --system --no-document --no-post-install-message
RubyGems 2.6.14 installed
=== 2.6.14 / 2017-10-09
Security fixes:
* Whitelist classes and symbols that are in loaded YAML.
  See CVE-2017-0903 for full details.
  Fix by Aaron Patterson.
=== 2.6.13 / 2017-08-27
Security fixes:
* Fix a DNS request hijacking vulnerability.
  Fix by Samuel Giddins.
* Fix an ANSI escape sequence vulnerability.
  Fix by Evan Phoenix.
* Fix a DOS vulernerability in the `query` command.
  Fix by Samuel Giddins.
* Fix a vulnerability in the gem installer that allowed
  a malicious gem to overwrite arbitrary files.
  Fix by Samuel Giddins.
=== 2.6.12 / 2017-04-30
Bug fixes:
* Fix test_self_find_files_with_gemfile to sort expected files. Pull
  request #1880 by Kazuaki Matsuo.
* Fix issue for MinGW / MSYS2 builds and testing. Pull request #1879 by
  MSP-Greg.
* Fix gem open to open highest version number rather than lowest. Pull
  request #1877 by Tim Pope.
* Add a test for requiring a default spec as installed by the ruby
  installer. Pull request #1899 by Samuel Giddins.
* Fix broken --exact parameter to gem command. Pull request #1873 by Jason
  Frey.
* [Installer] Generate backwards-compatible binstubs. Pull request #1904
  by Samuel Giddins.
* Fix pre-existing source recognition on add action. Pull request #1883 by
  Jonathan Claudius.
* Prevent negative IDs in output of #inspect. Pull request #1908 by Vít
  Ondruch.
* Allow Gem.finish_resolve to respect already-activated specs. Pull
  request #1910 by Samuel Giddins.
------------------------------------------------------------------------------
RubyGems installed the following executables:
	C:/Ruby23-x64/bin/gem
Updating rubygems-update
Successfully installed rubygems-update-2.6.14
Installing RubyGems 2.6.14
RubyGems system software updated
gem --version
2.6.14
where gem
C:\Ruby23-x64\bin\gem
C:\Ruby23-x64\bin\gem.bat
C:\Ruby23-x64\bin\gem.cmd
C:\Ruby193\bin\gem
C:\Ruby193\bin\gem.bat
gem install bundler
Successfully installed bundler-1.15.4
Parsing documentation for bundler-1.15.4
Installing ri documentation for bundler-1.15.4
Done installing documentation for bundler after 6 seconds
1 gem installed
bundle install
The git source `git://github.com/skywinder/github-changelog-generator.git` uses the `git` protocol, which transmits data without encryption. Disable this warning with `bundle config git.allow_insecure true`, or switch to the `https` protocol to keep your data secure.
Fetching git://github.com/skywinder/github-changelog-generator.git
Fetching gem metadata from http://rubygems.org/..........
Fetching version metadata from http://rubygems.org/...
Fetching dependency metadata from http://rubygems.org/..
Resolving dependencies...
Fetching rake 12.1.0
Installing rake 12.1.0
Fetching concurrent-ruby 1.0.5
Installing concurrent-ruby 1.0.5
Fetching i18n 0.8.6
Installing i18n 0.8.6
Fetching minitest 5.10.3
Installing minitest 5.10.3
Fetching thread_safe 0.3.6
Installing thread_safe 0.3.6
Fetching public_suffix 3.0.0
Installing public_suffix 3.0.0
Using bundler 1.15.4
Fetching multipart-post 2.0.0
Installing multipart-post 2.0.0
Fetching multi_json 1.12.2
Installing multi_json 1.12.2
Fetching retriable 3.1.1
Installing retriable 3.1.1
Fetching rainbow 2.2.2
Installing rainbow 2.2.2 with native extensions
Fetching tzinfo 1.2.3
Installing tzinfo 1.2.3
Fetching addressable 2.5.2
Installing addressable 2.5.2
Fetching faraday 0.13.1
Installing faraday 0.13.1
Fetching activesupport 5.1.4
Installing activesupport 5.1.4
Fetching faraday-http-cache 2.0.0
Installing faraday-http-cache 2.0.0
Fetching sawyer 0.8.1
Installing sawyer 0.8.1
Fetching octokit 4.7.0
Installing octokit 4.7.0
Using github_changelog_generator 1.15.0.pre.beta from git://github.com/skywinder/github-changelog-generator.git (at master@10e6287)
Bundle complete! 1 Gemfile dependency, 19 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
bundle exec github_changelog_generator
Usage: github_changelog_generator [options]
Command exited with code 1

@olleolleolle
Copy link
Collaborator

Perhaps you have a link to this build?

This latest build is for master of this repository, now.

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017

yes master

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017

Using github_changelog_generator 1.15.0.pre.beta from git://github.com/skywinder/github-changelog-generator.git (at master@10e6287)

@olleolleolle
Copy link
Collaborator

olleolleolle commented Oct 15, 2017 •
edited
Loading

@Furtif I'm still confused about the output your showed.

The command bundle exec github_changelog_generator, which could output

Usage: github_changelog_generator [options]
Command exited with code 1

(where I assume [options] means "a here truncated pretty-printing of the parsed options".)

does not exist as a build step – at least not in the AppVeyor build that I linked.

Do you have a build link to where AppVeyor fails that you can share?

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017

https://ci.appveyor.com/project/jjskuld/necrobot

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017 •
edited
Loading

appveyor conf

- git checkout -b Appveyor "%APPVEYOR_REPO_BRANCH%"
- SET PATH=C:\Ruby23-x64\bin;%PATH%
- ruby --version
- where ruby
- gem update --system --no-document --no-post-install-message
- gem --version
- where gem
- gem install bundler
- bundle install
- bundle exec github_changelog_generator
- git add "CHANGELOG.md"
- git commit -m "%APPVEYOR_REPO_TAG_NAME%"
- git checkout "%APPVEYOR_REPO_BRANCH%"
- git merge Appveyor
- git branch -d Appveyor
- git pull "origin" "%APPVEYOR_REPO_BRANCH%"
- git push "origin" "%APPVEYOR_REPO_BRANCH%"

before allright...

@olleolleolle
Copy link
Collaborator

Thanks for sharing this.

I was able to get to the same output situation using:

bundle exec bin/github_changelog_generator

I looked at the code and found that you must add: --user jjskuld --project necrobot

abort(parser.banner) unless options[:user] && options[:project]

@Furtif
Copy link
Author

Furtif commented Oct 15, 2017

here?

bundle exec github_changelog_generator

to

bundle exec bin/github_changelog_generator --user jjskuld --project necrobot

?

@olleolleolle olleolleolle mentioned this issue Oct 15, 2017
Merged
1 task
@olleolleolle
Copy link
Collaborator

The alternative is to store that information in a .github_changelog_generator configuration options file in the root of the project.

user=jjskuld
project=necrobot

@olleolleolle
Copy link
Collaborator

Hope this helps, and, thanks for the bug report.

@olleolleolle olleolleolle changed the title bug bug: Output on aborting when unknown user and project only prints out banner, not why it aborted Oct 16, 2017
@Furtif Furtif closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olleolleolle @Furtif