Skip to content

Specifying since-tag on a PR merge commit can cause that PR to be included #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
peppy opened this issue Jan 20, 2018 · 1 comment
Closed

Specifying since-tag on a PR merge commit can cause that PR to be included #615

peppy opened this issue Jan 20, 2018 · 1 comment

Comments

@peppy
Copy link

peppy commented Jan 20, 2018

When specifying a since-tag that corresponds to a PR merge commit (where the ref of the tag and the merge commit are equal) the PR is unexpectedly included in the changelog.

Tested on latest pre-release build using

github_changelog_generator -u ppy -p osu-framework --since-tag changelog-20180120 --max-issues 500 --no-issues --release-branch master

note that the state of this repository may change, let me know if i need to make an isolated test case.
@hunner hunner mentioned this issue Feb 16, 2018
Merged
@hunner
Copy link
Contributor

hunner commented Apr 12, 2018

This may be fixed in master now.

@peppy peppy closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hunner @peppy