Skip to content

Issue closed with github keyword seen in wrong place #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
paulfantom opened this issue Apr 14, 2018 · 0 comments
Open

Issue closed with github keyword seen in wrong place #642

paulfantom opened this issue Apr 14, 2018 · 0 comments
Labels
bug

Comments

@paulfantom
Copy link

paulfantom commented Apr 14, 2018 •
edited
Loading

Problem:

After merging PR which closes an issue and tagging this with git tag issue lands in "Upcoming" section of changelog and PR is in tagged one.

Steps taken:

  1. Create issue (example)
  2. Create PR and link it to issue with github keyword like related (example)
  3. Merge PR (example)
  4. Tag it with git tag (example)
  5. Generate changelog (example)

Expected:

Closed issue described in tagged section, not in "Upcoming".

Other info

Tagging and releasing is managed by this script and this line does actual changelog generation.

Version used: 1.14.3, also tested on master (3ed2fae)

This might be related to #560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skywinder @paulfantom