Skip to content

Multiple threads are doing the same task as each other #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jslight90 opened this issue Feb 28, 2020 · 0 comments
Open

Multiple threads are doing the same task as each other #767

jslight90 opened this issue Feb 28, 2020 · 0 comments

Comments

@jslight90
Copy link

The fetch_tag_shas_async method creates multiple threads that all call the oldest_commit method. Since the list of commits hasn't been fetched and cached yet, each thread starts fetching all the commits from the repository asynchronously and puts duplicates in the @commits array.

github-changelog-generator/lib/github_changelog_generator/octo_fetcher.rb

Line 321 in 3ad1dc9

commits_in_tag = fetch_compare(oldest_commit["sha"], tag["name"])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jslight90