Skip to content

Enabling branch protection for the master branch #793

Closed
@ferrarimarco

Description

@ferrarimarco

Hi! Happy to see activity in this repo!

So, I'd propose we enable some branch protection rules for the master branch:

  1. Require PR reviews before merging
  2. Require status checks to pass before merging
  3. (open to debate) Require liner history
  4. Enforce these rules on admins as well

On top of this, we might want to disable merge commits and rebase merging, to ensure the PR author:

  1. Takes care of rebasing against the latest master
  2. We end up with 1 commit for each PR, so it's easier to track what was done in that PR (easier cherry-pick, reverts...)

What do you think?

@olleolleolle @skywinder (and others! I lost track of the names of new maintainers, sorry! feel free to chime in :)

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions