-
-
Notifications
You must be signed in to change notification settings - Fork 849
--no-issues-wo-labels should not exclude Pull Requests #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm. Even with tag Example:
|
To me, it sounds like an option for a very strict project. "All labeled or not visible" to have no false positives. For that strict workflow, perhaps some diagnostic check "are there unlabeled issues/PRs in this range?" would be useful? Idk, I didn't use it like that. To support an "editorial hand" in the making, I've only used skipping, to exclude issues/PRs by label. The strict workflow could be seen as the polar opposite of my usage. I think your suggestion makes sense. Introducing it opens questions I can't answer "Are people relying on the old behavior? Would their regenerated CHANGELOG documents look wrong due to inclusion of old unlabeled PRs?" The fix for them would be to label those PRs skipped. There's a workaround. So, I'm for the change. |
Thanks. There are several points:
as the fact: we have an option "
So my option is to do 3 types of options:
So with the usage of 1 - everything would be the same as before. And then the rest to will work correctly |
I have just tried with the example above ( So, I think this issue can be closed. |
Now the option
--no-issues-wo-labels
exclude Pull Requests as well. I think it's not fair. Should we fix that, @olleolleolle?The text was updated successfully, but these errors were encountered: