Skip to content

Getting an error: 'list_issues': wrong number of arguments (given 3, expected 0..2) (ArgumentError) #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kigster opened this issue Mar 31, 2021 · 2 comments · Fixed by #949
Closed

Getting an error: 'list_issues': wrong number of arguments (given 3, expected 0..2) (ArgumentError) #952

kigster opened this issue Mar 31, 2021 · 2 comments · Fixed by #949
Labels
bug help wanted

Comments

@kigster
Copy link

kigster commented Mar 31, 2021 •
edited
Loading

Describe the bug

Running it on my private private repo, which does not have any issues logged, but does have a bunch of tags, although the same error happens even after I created a dummy issue.

$  cat .github_changelog_generator
since-tag=v0.2.0
$ github_changelog_generator --project YYYY --user XXXXX -t ZZZZZ
/Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/octokit-4.20.0/lib/octokit/client/issues.rb:30:in 'list_issues': wrong number of arguments (given 3, expected 0..2) (ArgumentError)
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/octo_fetcher.rb:415:in 'block in iterate_pages'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/retriable-3.1.2/lib/retriable.rb:61:in 'block in retriable'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/retriable-3.1.2/lib/retriable.rb:56:in 'times'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/retriable-3.1.2/lib/retriable.rb:56:in 'retriable'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/octo_fetcher.rb:446:in check_github_response'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/octo_fetcher.rb:415:in 'iterate_pages'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/octo_fetcher.rb:164:in 'fetch_closed_issues_and_pr'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/generator/generator.rb:144:in 'fetch_issues_and_pr'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/github_changelog_generator-1.16.1/lib/github_changelog_generator/generator/generator.rb:55:in 'block in compound_changelog'
	from /Users/kig/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/async-1.28.9/lib/async/task.rb:265:in 'block in make_fiber'

To Reproduce

Unfortunately, this is a private repo.

Ruby versions tried:

  • 3.0.0

Gem version tried:

  • 1.16.1
@olleolleolle
Copy link
Collaborator

olleolleolle commented Apr 1, 2021 •
edited
Loading

The method called is here:

https://github.com/github-changelog-generator/github-changelog-generator/blob/master/lib/github_changelog_generator/octo_fetcher.rb#L415

v1.15.2 version here:
https://github.com/github-changelog-generator/github-changelog-generator/blob/v1.15.2/lib/github_changelog_generator/octo_fetcher.rb#L372

And the Octokit 4.x method:
https://github.com/octokit/octokit.rb/blob/4-stable/lib/octokit/client/issues.rb#L30

@MikeRogers0 MikeRogers0 mentioned this issue Apr 2, 2021
Merged
@marcoroth
Copy link

If you need a public repo to reproduce the issue: We ran into the same issue in stimulus_reflex.

Downgrading github_changelog_generator to v1.15.2 seems to resolve the issue for us.

Locally I can reproduce the ArgumentError with this using Ruby 3.0.0 and 1.16.1:

github_changelog_generator -u hopsoft -p stimulus_reflex --exclude-labels duplicate,question,invalid,wontfix,nodoc --token {token}

@cormacrelf cormacrelf mentioned this issue Apr 6, 2021
Closed
@olleolleolle olleolleolle linked a pull request Apr 6, 2021 that will close this issue
Support Ruby 3 #949
Merged
@jackton1 jackton1 mentioned this issue Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
3 participants
@olleolleolle @kigster @marcoroth