-
-
Notifications
You must be signed in to change notification settings - Fork 849
--front-matter raises a NoMethodError for #to_yaml #962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would call it a bug, one which perhaps occurs for users that do not use the Rake task way of configuration - since there they have the full power of Ruby - they can add "\n" as they want to in their configuration line. Are you using the configuration file way of configuring, here? (Asking to narrow down where to try finding the current behavior.) Proposed Workaround 1: use a Rakefile and configure the task with Rake. Update:
By formatting your test as a JSON string, you can add newlines. But, this makes me thing of YAML front-matter: it's not just a text section, it has a specific meaning. It is meant to be a section for YAML configuration of the Markdown document. Metadata, information that can't be inside the document. |
I am using the docker image and the configuration file |
An example input in the field would be something like
which would turn into a YAML preamble aka front-matter. If you try adding that single option as a CLI configuration option, does that generate a YAML frontmatter? |
Thanks a lot @olleolleolle for your fast reply and help. So, that seems to raise an error instead:
command: docker run -it --rm -e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHUB_TOKEN \
-v "$(pwd)":/usr/local/src/your-app \
githubchangeloggenerator/github-changelog-generator \
--user apache \
--project arrow-rs \
--since-commit 2021-04-20 \
--future-release 4.0.1 \
--front-matter '{"hello":"world"}' |
@jorgecarleitao That's good news, since we can change the to_yaml to a YAML.generate implementation instead. Update: The problem was just that the YAML library was not yet loaded. |
The bug fix has been released as v1.16.3. |
wow, thank you so much for such a quick reaction, fix and release ❤️ Much appreciated, @olleolleolle ! |
Does this release triggered the release of a new docker image? |
@jorgecarleitao I don't think that it does. I don't know exactly how that works, though! |
Describe the bug
When the changelog is created with a section
front-matter=For older versions, see X
, the output isi.e. there is no break line.
Is there a way to fix this as a user, or is it a bug?
The text was updated successfully, but these errors were encountered: