From 81af09713fc788cceb25bb94ff1da9da56b467fb Mon Sep 17 00:00:00 2001 From: Dusan Plavak Date: Tue, 21 Jan 2020 14:10:09 +0800 Subject: [PATCH 1/2] Fix not parsing body_only param for sections --- lib/github_changelog_generator/generator/entry.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/github_changelog_generator/generator/entry.rb b/lib/github_changelog_generator/generator/entry.rb index ac85ea5a3..e0eec63d2 100644 --- a/lib/github_changelog_generator/generator/entry.rb +++ b/lib/github_changelog_generator/generator/entry.rb @@ -72,7 +72,7 @@ def parse_sections(sections_desc) end sections_json.collect do |name, v| - Section.new(name: name.to_s, prefix: v["prefix"], labels: v["labels"], options: @options) + Section.new(name: name.to_s, prefix: v["prefix"], labels: v["labels"], body_only: v["body_only"], options: @options) end end From cbc1b0954b2f32a70266ff7af19ab6338fae7284 Mon Sep 17 00:00:00 2001 From: Dusan Plavak Date: Tue, 21 Jan 2020 16:08:01 +0800 Subject: [PATCH 2/2] Add regression test --- spec/unit/generator/entry_spec.rb | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/spec/unit/generator/entry_spec.rb b/spec/unit/generator/entry_spec.rb index 8626189d7..3dce05093 100644 --- a/spec/unit/generator/entry_spec.rb +++ b/spec/unit/generator/entry_spec.rb @@ -426,6 +426,18 @@ def default_sections sections_json.shift end end + context "parse also body_only" do + let(:sections_string) { "{ \"foo\": { \"prefix\": \"foofix\", \"labels\": [\"test1\", \"test2\"]}, \"bar\": { \"prefix\": \"barfix\", \"labels\": [\"test3\", \"test4\"], \"body_only\": true}}" } + + it "returns correctly constructed sections" do + require "json" + + parsed_sections = subject.send(:parse_sections, sections_string) + + expect(parsed_sections[0].body_only).to eq false + expect(parsed_sections[1].body_only).to eq true + end + end end context "hash" do let(:sections_hash) do