Skip to content

Revert "More concurrency" #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "More concurrency" #934

wants to merge 2 commits into from

Conversation

ameir
Copy link
Contributor

@ameir ameir commented Feb 18, 2021

Reverts #921

With the async code in place, I get:

Traceback (most recent call last):
        1362: from /usr/local/bundle/gems/async-1.28.9/lib/async/task.rb:265:in `block in make_fiber'
        1361: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/generator/generator.rb:55:in `block in compound_changelog'
        1360: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/generator/generator.rb:152:in `fetch_issues_and_pr'
        1359: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/generator/generator_fetcher.rb:48:in `add_first_occurring_tag_to_prs'
        1358: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/generator/generator_fetcher.rb:65:in `associate_tagged_prs'
        1357: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:367:in `fetch_tag_shas'
        1356: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:367:in `each'
        1355: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:368:in `block in fetch_tag_shas'
         ... 1350 levels...
           4: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:353:in `commits_in_tag'
           3: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:353:in `each'
           2: from /usr/local/bundle/gems/github_changelog_generator-1.15.2/lib/github_changelog_generator/octo_fetcher.rb:354:in `block in commits_in_tag'
           1: from /usr/local/bundle/gems/sawyer-0.8.2/lib/sawyer/resource.rb:54:in `[]'
/usr/local/bundle/gems/sawyer-0.8.2/lib/sawyer/resource.rb:56:in `rescue in []': stack level too deep (SystemStackError)

But the generation works without it. I like the async, but it needs more testing.

@ameir ameir mentioned this pull request Feb 18, 2021
Merged
@olleolleolle
Copy link
Collaborator

👋 Thanks for the PR, but currently, things work again – see #936 for a repair.

@ameir
Copy link
Contributor Author

ameir commented Feb 19, 2021

Excellent news! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameir @olleolleolle