.`).not.toHaveBeenWarned() + expect(spy.calls.allArgs()).toEqual([['regular']]); // Regular @click should work for dynamic components resolved to native HTML elements. + }) + it('.once modifier should work with child components', () => { vm = new Vue({ el, @@ -962,6 +976,17 @@ describe('Directive v-on', () => { expect(value).toBe(1) }) + it('should not execute callback if modifiers are present', () => { + vm = new Vue({ + el, + template: '', + methods: { foo: spy } + }) + // simulating autocomplete event (Event object with type keyup but without keyCode) + triggerEvent(vm.$el, 'keyup') + expect(spy.calls.count()).toBe(0) + }) + describe('dynamic arguments', () => { it('basic', done => { const spy = jasmine.createSpy() diff --git a/test/unit/features/error-handling.spec.js b/test/unit/features/error-handling.spec.js index 7d0eaa512ab..7dd36dc9f1f 100644 --- a/test/unit/features/error-handling.spec.js +++ b/test/unit/features/error-handling.spec.js @@ -127,25 +127,25 @@ describe('Error handling', () => { }).then(done) }) - it('should recover from errors in user watcher callback', done => { - const vm = createTestInstance(components.userWatcherCallback) - vm.n++ - waitForUpdate(() => { - expect(`Error in callback for watcher "n"`).toHaveBeenWarned() - expect(`Error: userWatcherCallback`).toHaveBeenWarned() - }).thenWaitFor(next => { - assertBothInstancesActive(vm).end(next) - }).then(done) - }) + ;[ + ['userWatcherCallback', 'watcher'], + ['userImmediateWatcherCallback', 'immediate watcher'] + ].forEach(([type, description]) => { + it(`should recover from errors in user ${description} callback`, done => { + const vm = createTestInstance(components[type]) + assertBothInstancesActive(vm).then(() => { + expect(`Error in callback for ${description} "n"`).toHaveBeenWarned() + expect(`Error: ${type} error`).toHaveBeenWarned() + }).then(done) + }) - it('should recover from errors in user immediate watcher callback', done => { - const vm = createTestInstance(components.userImmediateWatcherCallback) - waitForUpdate(() => { - expect(`Error in callback for immediate watcher "n"`).toHaveBeenWarned() - expect(`Error: userImmediateWatcherCallback error`).toHaveBeenWarned() - }).thenWaitFor(next => { - assertBothInstancesActive(vm).end(next) - }).then(done) + it(`should recover from promise errors in user ${description} callback`, done => { + const vm = createTestInstance(components[`${type}Async`]) + assertBothInstancesActive(vm).then(() => { + expect(`Error in callback for ${description} "n" (Promise/async)`).toHaveBeenWarned() + expect(`Error: ${type} error`).toHaveBeenWarned() + }).then(done) + }) }) it('config.errorHandler should capture render errors', done => { @@ -359,6 +359,33 @@ function createErrorTestComponents () { } } + components.userWatcherCallbackAsync = { + props: ['n'], + watch: { + n () { + return Promise.reject(new Error('userWatcherCallback error')) + } + }, + render (h) { + return h('div', this.n) + } + } + + components.userImmediateWatcherCallbackAsync = { + props: ['n'], + watch: { + n: { + immediate: true, + handler () { + return Promise.reject(new Error('userImmediateWatcherCallback error')) + } + } + }, + render (h) { + return h('div', this.n) + } + } + // event errors components.event = { beforeCreate () { diff --git a/test/unit/features/filter/filter.spec.js b/test/unit/features/filter/filter.spec.js index 82c57a3d62e..854ea575064 100644 --- a/test/unit/features/filter/filter.spec.js +++ b/test/unit/features/filter/filter.spec.js @@ -194,4 +194,11 @@ describe('Filters', () => { it('support template string', () => { expect(parseFilters('`a | ${b}c` | d')).toBe('_f("d")(`a | ${b}c`)') }) + + it('bigint support', () => { + const vm = new Vue({ + template: `

` + }).$mount() + expect(vm.$el.textContent).toBe('6000000010000000') + }) }) diff --git a/test/unit/features/global-api/set-delete.spec.js b/test/unit/features/global-api/set-delete.spec.js index d1c7f3d8709..59e75ae4dbe 100644 --- a/test/unit/features/global-api/set-delete.spec.js +++ b/test/unit/features/global-api/set-delete.spec.js @@ -14,7 +14,7 @@ describe('Global API: set/delete', () => { }).then(done) }) - it('should update a observing object', done => { + it('should update an observing object', done => { const vm = new Vue({ template: '

', data: { foo: { x: 1 }} @@ -26,7 +26,7 @@ describe('Global API: set/delete', () => { }).then(done) }) - it('should update a observing array', done => { + it('should update an observing array', done => { const vm = new Vue({ template: '

{{k}}-{{v}}

', data: { list: ['a', 'b', 'c'] } diff --git a/test/unit/features/instance/methods-lifecycle.spec.js b/test/unit/features/instance/methods-lifecycle.spec.js index 1e424a5c9be..a2c5b86e920 100644 --- a/test/unit/features/instance/methods-lifecycle.spec.js +++ b/test/unit/features/instance/methods-lifecycle.spec.js @@ -53,6 +53,38 @@ describe('Instance methods lifecycle', () => { } }).$mount() }) + + it('Dep.target should be undefined during invocation of child immediate watcher', done => { + let calls = 0 + const childData = { a: 1 } + const parentUpdate = jasmine.createSpy() + new Vue({ + template: '

', + updated: parentUpdate, + components: { + myComponent: { + template: '

', + data() { + return childData + }, + watch: { + anything: { + handler() { + ++calls + this.a + }, + immediate: true + } + } + } + } + }).$mount() + expect(calls).toBe(1) + childData.a++ + waitForUpdate(() => { + expect(parentUpdate).not.toHaveBeenCalled() + }).then(done) + }) }) describe('$destroy', () => { diff --git a/test/unit/features/options/computed.spec.js b/test/unit/features/options/computed.spec.js index edc20bad3bf..17cd9516640 100644 --- a/test/unit/features/options/computed.spec.js +++ b/test/unit/features/options/computed.spec.js @@ -206,6 +206,18 @@ describe('Options computed', () => { expect(`computed property "a" is already defined as a prop`).toHaveBeenWarned() }) + it('warn conflict with methods', () => { + new Vue({ + computed: { + a: () => 2 + }, + methods: { + a: () => {} + } + }) + expect(`computed property "a" is already defined as a method`).toHaveBeenWarned() + }) + it('rethrow computed error', () => { const vm = new Vue({ computed: { diff --git a/test/unit/features/options/errorCaptured.spec.js b/test/unit/features/options/errorCaptured.spec.js index 3da13b9ed38..0c1aba35b79 100644 --- a/test/unit/features/options/errorCaptured.spec.js +++ b/test/unit/features/options/errorCaptured.spec.js @@ -247,4 +247,152 @@ describe('Options errorCaptured', () => { expect(store.errors[0]).toEqual(new Error('render error')) }).then(done) }) + + it('should capture error from watcher', done => { + const spy = jasmine.createSpy() + + let child + let err + const Child = { + data () { + return { + foo: null + } + }, + watch: { + foo () { + err = new Error('userWatcherCallback error') + throw err + } + }, + created () { + child = this + }, + render () {} + } + + new Vue({ + errorCaptured: spy, + render: h => h(Child) + }).$mount() + + child.foo = 'bar' + + waitForUpdate(() => { + expect(spy).toHaveBeenCalledWith(err, child, 'callback for watcher "foo"') + expect(globalSpy).toHaveBeenCalledWith(err, child, 'callback for watcher "foo"') + }).then(done) + }) + + it('should capture promise error from watcher', done => { + const spy = jasmine.createSpy() + + let child + let err + const Child = { + data () { + return { + foo: null + } + }, + watch: { + foo () { + err = new Error('userWatcherCallback error') + return Promise.reject(err) + } + }, + created () { + child = this + }, + render () {} + } + + new Vue({ + errorCaptured: spy, + render: h => h(Child) + }).$mount() + + child.foo = 'bar' + + child.$nextTick(() => { + waitForUpdate(() => { + expect(spy).toHaveBeenCalledWith(err, child, 'callback for watcher "foo" (Promise/async)') + expect(globalSpy).toHaveBeenCalledWith(err, child, 'callback for watcher "foo" (Promise/async)') + }).then(done) + }) + }) + + it('should capture error from immediate watcher', done => { + const spy = jasmine.createSpy() + + let child + let err + const Child = { + data () { + return { + foo: 'foo' + } + }, + watch: { + foo: { + immediate: true, + handler () { + err = new Error('userImmediateWatcherCallback error') + throw err + } + } + }, + created () { + child = this + }, + render () {} + } + + new Vue({ + errorCaptured: spy, + render: h => h(Child) + }).$mount() + + waitForUpdate(() => { + expect(spy).toHaveBeenCalledWith(err, child, 'callback for immediate watcher "foo"') + expect(globalSpy).toHaveBeenCalledWith(err, child, 'callback for immediate watcher "foo"') + }).then(done) + }) + + it('should capture promise error from immediate watcher', done => { + const spy = jasmine.createSpy() + + let child + let err + const Child = { + data () { + return { + foo: 'foo' + } + }, + watch: { + foo: { + immediate: true, + handler () { + err = new Error('userImmediateWatcherCallback error') + return Promise.reject(err) + } + } + }, + created () { + child = this + }, + render () {} + } + + new Vue({ + errorCaptured: spy, + render: h => h(Child) + }).$mount() + + waitForUpdate(() => { + expect(spy).toHaveBeenCalledWith(err, child, 'callback for immediate watcher "foo" (Promise/async)') + expect(globalSpy).toHaveBeenCalledWith(err, child, 'callback for immediate watcher "foo" (Promise/async)') + }).then(done) + }) }) diff --git a/test/unit/features/options/props.spec.js b/test/unit/features/options/props.spec.js index b2bf482737b..2ada45a0553 100644 --- a/test/unit/features/options/props.spec.js +++ b/test/unit/features/options/props.spec.js @@ -252,6 +252,16 @@ describe('Options props', () => { expect('Expected String, Number, got Symbol').toHaveBeenWarned() }) } + + if (typeof BigInt !== 'undefined') { + /* global BigInt */ + it('bigint', () => { + makeInstance(BigInt(100), BigInt) + expect(console.error.calls.count()).toBe(0) + makeInstance({}, BigInt) + expect('Expected BigInt, got Object').toHaveBeenWarned() + }) + } it('custom constructor', () => { function Class () {} @@ -553,4 +563,20 @@ describe('Options props', () => { expect(vm.$refs.test.$props.booleanOrString).toBe(true) expect(vm.$refs.test.$props.stringOrBoolean).toBe('') }) + + it('should warn when a prop type is not a constructor', () => { + const vm = new Vue({ + template: '

', + props: { + a: { + type: 'String', + default: 'test' + } + } + }).$mount() + expect( + 'Invalid prop type: "String" is not a constructor' + ).toHaveBeenWarned() + }) + }) diff --git a/test/unit/modules/compiler/codegen.spec.js b/test/unit/modules/compiler/codegen.spec.js index d7faa204944..a31f751d64e 100644 --- a/test/unit/modules/compiler/codegen.spec.js +++ b/test/unit/modules/compiler/codegen.spec.js @@ -196,7 +196,7 @@ describe('codegen', () => { it('generate slot fallback content', () => { assertCodegen( '

', - `with(this){return _c('div',[_t("default",[_c('div',[_v("hi")])])],2)}` + `with(this){return _c('div',[_t("default",function(){return [_c('div',[_v("hi")])]})],2)}` ) }) diff --git a/test/unit/modules/compiler/parser.spec.js b/test/unit/modules/compiler/parser.spec.js index 360bc11bbb6..b47de581396 100644 --- a/test/unit/modules/compiler/parser.spec.js +++ b/test/unit/modules/compiler/parser.spec.js @@ -865,6 +865,14 @@ describe('parser', () => { expect(ast.children[4].children[0].text).toBe('. Have fun! ') }) + it(`maintains with whitespace: 'condense'`, () => { + const options = extend({}, condenseOptions) + const ast = parse(' ', options) + const code = ast.children[0] + expect(code.type).toBe(3) + expect(code.text).toBe('\xA0') + }) + it(`preserve whitespace in

 tag with whitespace: 'condense'`, function () {
     const options = extend({}, condenseOptions)
     const ast = parse('  \nhi\n   ', options)
@@ -901,4 +909,20 @@ describe('parser', () => {
     expect(ast.children[2].type).toBe(3)
     expect(ast.children[2].text).toBe('\ndef')
   })
+
+  // #10152
+  it('not warn when scoped slot used inside of dynamic component on regular element', () => {
+    parse(`
+      
+        
+        
+        
+      
+    `, baseOptions)
+    expect('v-slot can only be used on components or

- - - -	- - - -	- - - -	- - - -
- - - -

- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -

- - - -	- - - -	- - - -	- - - -
- - - -

- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -	- - - -	- - - -	- - - -	- - - -	- - - -
- - - -

Sponsors & Backers

Special Sponsors

Platinum via Patreon

Platinum Sponsors (China)

Platinum via OpenCollective

Gold via Patreon

Gold via OpenCollective

Silver via Patreon

Silver via OpenCollective

Bronze via Patreon

Bronze via OpenCollective

Generous Backers via Patreon ($50+)

Backers via Patreon

Backers via OpenCollective

Supporting Vue.js

Special Sponsors

Platinum Sponsors

Platinum Sponsors (China)

Gold Sponsors

Sponsors via Open Collective

Platinum

Gold