Skip to content

Commit 55d479e

Browse files
author
Pawel Slomka
committed
Fix create/drop numeric-named databases
1 parent dbff74e commit 55d479e

File tree

2 files changed

+30
-4
lines changed

2 files changed

+30
-4
lines changed

influxdb/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,15 +460,15 @@ def create_database(self, dbname):
460460
:param dbname: the name of the database to create
461461
:type dbname: str
462462
"""
463-
self.query("CREATE DATABASE %s" % dbname)
463+
self.query("CREATE DATABASE \"%s\"" % dbname)
464464

465465
def drop_database(self, dbname):
466466
"""Drop a database from InfluxDB.
467467
468468
:param dbname: the name of the database to drop
469469
:type dbname: str
470470
"""
471-
self.query("DROP DATABASE %s" % dbname)
471+
self.query("DROP DATABASE \"%s\"" % dbname)
472472

473473
def create_retention_policy(self, name, duration, replication,
474474
database=None, default=False):

influxdb/tests/client_test.py

Lines changed: 28 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,20 @@ def test_create_database(self):
407407
self.cli.create_database('new_db')
408408
self.assertEqual(
409409
m.last_request.qs['q'][0],
410-
'create database new_db'
410+
'create database "new_db"'
411+
)
412+
413+
def test_create_numeric_named_database(self):
414+
with requests_mock.Mocker() as m:
415+
m.register_uri(
416+
requests_mock.GET,
417+
"http://localhost:8086/query",
418+
text='{"results":[{}]}'
419+
)
420+
self.cli.create_database('123')
421+
self.assertEqual(
422+
m.last_request.qs['q'][0],
423+
'create database "123"'
411424
)
412425

413426
@raises(Exception)
@@ -425,7 +438,20 @@ def test_drop_database(self):
425438
self.cli.drop_database('new_db')
426439
self.assertEqual(
427440
m.last_request.qs['q'][0],
428-
'drop database new_db'
441+
'drop database "new_db"'
442+
)
443+
444+
def test_drop_numeric_named_database(self):
445+
with requests_mock.Mocker() as m:
446+
m.register_uri(
447+
requests_mock.GET,
448+
"http://localhost:8086/query",
449+
text='{"results":[{}]}'
450+
)
451+
self.cli.drop_database('123')
452+
self.assertEqual(
453+
m.last_request.qs['q'][0],
454+
'drop database "123"'
429455
)
430456

431457
@raises(Exception)

0 commit comments

Comments
 (0)