Don't append 'i' to bools (Closes: influxdata#235)

aviau · aviau · commit b081fa1c4928 · 2015-08-30T21:17:40.000-04:00
diff --git a/influxdb/line_protocol.py b/influxdb/line_protocol.py
@@ -59,7 +59,7 @@ def _escape_value(value):
                 "\n", "\\n"
             )
         )
-    elif isinstance(value, integer_types):
+    elif isinstance(value, integer_types) and not isinstance(value, bool):
         return str(value) + 'i'
     else:
         return str(value)
diff --git a/influxdb/tests/test_line_protocol.py b/influxdb/tests/test_line_protocol.py
@@ -22,6 +22,7 @@ def test_make_lines(self):
                         "int_val": 1,
                         "float_val": 1.1,
                         "none_field": None,
+                        "bool_val": True,
                     }
                 }
             ]
@@ -30,7 +31,7 @@ def test_make_lines(self):
         self.assertEqual(
             line_protocol.make_lines(data),
             'test,integer_tag=2,string_tag=hello '
-            'float_val=1.1,int_val=1i,string_val="hello!"\n'
+            'bool_val=True,float_val=1.1,int_val=1i,string_val="hello!"\n'
         )
 
     def test_string_val_newline(self):

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ def _escape_value(value):`
`59`	`59`	`"\n", "\\n"`
`60`	`60`	`)`
`61`	`61`	`)`
`62`		`- elif isinstance(value, integer_types):`
	`62`	`+ elif isinstance(value, integer_types) and not isinstance(value, bool):`
`63`	`63`	`return str(value) + 'i'`
`64`	`64`	`else:`
`65`	`65`	`return str(value)`
Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,7 @@ def test_make_lines(self):`
`22`	`22`	`"int_val": 1,`
`23`	`23`	`"float_val": 1.1,`
`24`	`24`	`"none_field": None,`
	`25`	`+ "bool_val": True,`
`25`	`26`	`}`
`26`	`27`	`}`
`27`	`28`	`]`
`@@ -30,7 +31,7 @@ def test_make_lines(self):`
`30`	`31`	`self.assertEqual(`
`31`	`32`	`line_protocol.make_lines(data),`
`32`	`33`	`'test,integer_tag=2,string_tag=hello '`
`33`		`- 'float_val=1.1,int_val=1i,string_val="hello!"\n'`
	`34`	`+ 'bool_val=True,float_val=1.1,int_val=1i,string_val="hello!"\n'`
`34`	`35`	`)`
`35`	`36`
`36`	`37`	`def test_string_val_newline(self):`