fixed issue with running a 'git log' with an object that won't rev-parse (file)

scott Chacon · scott Chacon · commit 6a9db968e856 · 2007-11-27T08:21:28.000-08:00
diff --git a/camping/gitweb.rb b/camping/gitweb.rb
@@ -116,10 +116,7 @@ def get repo_id, sha
   class Tree < R '/tree/(\d+)/(\w+)'
     def get repo_id, sha
       @repo = Repository.find repo_id
-      logger = Logger.new('/tmp/git.log')
-      logger.level = Logger::INFO
-      
-      @git = Git.bare(@repo.path, :log => logger)      
+      @git = Git.bare(@repo.path)   
       @tree = @git.gtree(sha)
       render :tree
     end
@@ -128,7 +125,10 @@ def get repo_id, sha
   class Blob < R '/blob/(\d+)/(.*?)/(\w+)'
     def get repo_id, file, sha
       @repo = Repository.find repo_id
-      @git = Git.bare(@repo.path)      
+      logger = Logger.new('/tmp/git.log')
+      logger.level = Logger::INFO
+      
+      @git = Git.bare(@repo.path, :log => logger)      
       @blob = @git.gblob(sha)
       @file = file
       render :blob
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -81,8 +81,10 @@ def full_log_commits(opts = {})
         sha = revparse(opts[:object] || branch_current || 'master')
         count = opts[:count] || 30
         
-        repo = get_raw_repo
-        return process_commit_data(repo.log(sha, count))
+        if /\w{40}/.match(sha)  # valid sha
+          repo = get_raw_repo
+          return process_commit_data(repo.log(sha, count))
+        end
       end
       
       arr_opts = ['--pretty=raw']
diff --git a/tests/units/test_log.rb b/tests/units/test_log.rb
@@ -1,10 +1,11 @@
 #!/usr/bin/env ruby
-
+require 'logger'
 require File.dirname(__FILE__) + '/../test_helper'
 
 class TestLog < Test::Unit::TestCase
   def setup
     set_file_paths
+    #@git = Git.open(@wdir, :log => Logger.new(STDOUT))
     @git = Git.open(@wdir)
   end
 
diff --git a/tests/units/test_raw_internals.rb b/tests/units/test_raw_internals.rb
@@ -22,8 +22,7 @@ def test_packed_log
   end
   
   def test_commit_object
-    g = Git.bare(@wbare, :log => Logger.new(STDOUT))
-    
+    g = Git.bare(@wbare)    
     c = g.gcommit("v2.5")
     assert_equal('test', c.message)
   end
@@ -34,7 +33,7 @@ def test_lstree
     sha = c.sha
     
     repo = Git::Raw::Repository.new(@wbare)
-    puts repo.object(sha).inspect
+    assert_equal('ex_dir', repo.object(sha).entry.first.name)
   end
   
   def t_log(g)
