Merge pull request docker-java#474 from KostyaSha/backportNullFix

marcuslinke · marcuslinke · commit 0a80020a5be7 · 2016-02-23T20:00:41.000+01:00
Fix periodic pull failure (2.x)
diff --git a/src/main/java/com/github/dockerjava/core/async/JsonStreamProcessor.java b/src/main/java/com/github/dockerjava/core/async/JsonStreamProcessor.java
@@ -10,6 +10,7 @@
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.JsonToken;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.github.dockerjava.api.async.ResultCallback;
 
 /**
@@ -41,8 +42,12 @@ public void processResponseStream(InputStream response, ResultCallback<T> result
             JsonToken nextToken = jp.nextToken();
             while (!closed && nextToken != null && nextToken != JsonToken.END_OBJECT) {
                 try {
-                    T next = OBJECT_MAPPER.readValue(jp, clazz);
-                    resultCallback.onNext(next);
+                    ObjectNode objectNode = OBJECT_MAPPER.readTree(jp);
+                    // exclude empty item serialization into class #461
+                    if (!(objectNode.size() == 0)) {
+                        T next = OBJECT_MAPPER.treeToValue(objectNode, clazz);
+                        resultCallback.onNext(next);
+                    }
                 } catch (Exception e) {
                     resultCallback.onError(e);
                 }
diff --git a/src/test/java/com/github/dockerjava/core/async/JsonStreamProcessorTest.java b/src/test/java/com/github/dockerjava/core/async/JsonStreamProcessorTest.java
@@ -0,0 +1,65 @@
+/*
+ * Created on 16.02.2016
+ */
+package com.github.dockerjava.core.async;
+
+import static org.testng.Assert.assertFalse;
+
+import java.io.ByteArrayInputStream;
+import java.io.Closeable;
+import java.io.IOException;
+import java.io.InputStream;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.testng.annotations.Test;
+
+import com.github.dockerjava.api.async.ResultCallback;
+import com.github.dockerjava.api.model.PullResponseItem;
+
+
+/**
+ *
+ * @author Marcus Linke
+ *
+ */
+public class JsonStreamProcessorTest {
+
+    @Test
+    public void processEmptyJson() throws Exception {
+
+        InputStream response = new ByteArrayInputStream("{}".getBytes());
+
+        JsonStreamProcessor<PullResponseItem> jsonStreamProcessor = new JsonStreamProcessor<PullResponseItem>(PullResponseItem.class);
+
+        final List<Boolean> completed = new ArrayList<Boolean>();
+
+        jsonStreamProcessor.processResponseStream(response, new ResultCallback<PullResponseItem>() {
+
+            @Override
+            public void close() throws IOException {
+            }
+
+            @Override
+            public void onStart(Closeable closeable) {
+            }
+
+            @Override
+            public void onNext(PullResponseItem object) {
+                assertFalse(true, "onNext called for empty json");
+            }
+
+            @Override
+            public void onError(Throwable throwable) {
+            }
+
+            @Override
+            public void onComplete() {
+                completed.add(true);
+            }
+        });
+
+        assertFalse(completed.isEmpty(), "Stream processing not completed");
+    }
+
+}
