Merge branch '2.8' into 3.3

javiereguiluz · javiereguiluz · commit 88b7768bb5f5 · 2018-01-29T17:52:57.000+01:00
* 2.8:
  Fixed the priority of the sticky locale example
  Fixed the types of some options in Collection constraint
  Update finder.rst
  Handler formatter example was using wrong defined service
  Update doctrine.rst
  Add example for Finder::exclude
  Update form_csrf_caching.rst
  do never fetch private services from the container
diff --git a/components/finder.rst b/components/finder.rst
@@ -103,6 +103,7 @@ Each pattern has to resolve to at least one directory path.
 Exclude directories from matching with the
 :method:`Symfony\\Component\\Finder\\Finder::exclude` method::
 
+    // directories passed as argument must be relative to the ones defined with the in() method
     $finder->in(__DIR__)->exclude('ruby');
 
 It's also possible to ignore directories that you don't have permission to read::
diff --git a/http_cache/form_csrf_caching.rst b/http_cache/form_csrf_caching.rst
@@ -36,7 +36,8 @@ Another option would be to load the form via an uncached AJAX request, but
 cache the rest of the HTML response.
 
 Or you can even load just the CSRF token with an AJAX request and replace the
-form field value with it.
+form field value with it. Take a look at :doc:`hinclude.js </templating/hinclude>`
+for a nice solution.
 
 .. _`Cross-site request forgery`: http://en.wikipedia.org/wiki/Cross-site_request_forgery
 .. _`Security CSRF Component`: https://github.com/symfony/security-csrf
diff --git a/logging/processors.rst b/logging/processors.rst
@@ -139,7 +139,7 @@ Finally, set the formatter to be used on whatever handler you want:
                     type="stream"
                     path="%kernel.logs_dir%/%kernel.environment%.log"
                     level="debug"
-                    formatter="app.logger.session_request_processor"
+                    formatter="monolog.formatter.session_request"
                 />
             </monolog:config>
         </container>
@@ -153,7 +153,7 @@ Finally, set the formatter to be used on whatever handler you want:
                     'type'      => 'stream',
                     'path'      => '%kernel.logs_dir%/%kernel.environment%.log',
                     'level'     => 'debug',
-                    'formatter' => 'app.logger.session_request_processor',
+                    'formatter' => 'monolog.formatter.session_request',
                 ),
             ),
         ));
diff --git a/reference/configuration/doctrine.rst b/reference/configuration/doctrine.rst
@@ -31,7 +31,12 @@ Full Default Configuration
                         port:                 ~
                         user:                 root
                         password:             ~
+                        # charset of the database
                         charset:              ~
+                        # charset and collation of the tables. Not inherited from database
+                        default_table_options:
+                            charset:          ~
+                            collate:          ~
                         path:                 ~
                         memory:               ~
 
diff --git a/reference/constraints/Collection.rst b/reference/constraints/Collection.rst
@@ -310,7 +310,7 @@ error will be returned. If set to ``true``, extra fields are ok.
 extraFieldsMessage
 ~~~~~~~~~~~~~~~~~~
 
-**type**: ``boolean`` **default**: ``This field was not expected.``
+**type**: ``string`` **default**: ``This field was not expected.``
 
 The message shown if `allowExtraFields`_ is false and an extra field is
 detected.
@@ -328,7 +328,7 @@ option are not present in the underlying collection.
 missingFieldsMessage
 ~~~~~~~~~~~~~~~~~~~~
 
-**type**: ``boolean`` **default**: ``This field is missing.``
+**type**: ``string`` **default**: ``This field is missing.``
 
 The message shown if `allowMissingFields`_ is false and one or more fields
 are missing from the underlying collection.
diff --git a/service_container/alias_private.rst b/service_container/alias_private.rst
@@ -65,17 +65,15 @@ gives you better errors: if you try to reference a non-existent service, you wil
 get a clear error when you refresh *any* page, even if the problematic code would
 not have run on that page.
 
-Now that the service is private, you *should not* fetch the service directly
+Now that the service is private, you *must not* fetch the service directly
 from the container::
 
     use AppBundle\Service\Foo;
 
     $container->get(Foo::class);
 
-This *may or may not work*, depending on how the container has optimized the
-service instantiation and, even in the cases where it works, this possibility is
-deprecated. Simply said: A service should be marked as private if you do not want
-to access it directly from your code.
+Simply said: A service can be marked as private if you do not want to access
+it directly from your code.
 
 However, if a service has been marked as private, you can still alias it
 (see below) to access this service (via the alias).
diff --git a/session/locale_sticky_session.rst b/session/locale_sticky_session.rst
@@ -52,8 +52,8 @@ correct locale however you want::
         public static function getSubscribedEvents()
         {
             return array(
-                // must be registered after the default Locale listener
-                KernelEvents::REQUEST => array(array('onKernelRequest', 15)),
+                // must be registered before (i.e. with a higher priority than) the default Locale listener
+                KernelEvents::REQUEST => array(array('onKernelRequest', 20)),
             );
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -52,8 +52,8 @@ correct locale however you want::`
`52`	`52`	`public static function getSubscribedEvents()`
`53`	`53`	`{`
`54`	`54`	`return array(`
`55`		`- // must be registered after the default Locale listener`
`56`		`- KernelEvents::REQUEST => array(array('onKernelRequest', 15)),`
	`55`	`+ // must be registered before (i.e. with a higher priority than) the default Locale listener`
	`56`	`+ KernelEvents::REQUEST => array(array('onKernelRequest', 20)),`
`57`	`57`	`);`
`58`	`58`	`}`
`59`	`59`	`}`