minor symfony#17200 Inappropriate usage of Parameter Conversion (githubfromgui)

javiereguiluz · javiereguiluz · commit c97906801f48 · 2022-09-02T17:48:24.000+02:00
This PR was merged into the 4.4 branch. Discussion ---------- Inappropriate usage of Parameter Conversion Under the section `Route Groups and Prefixes`, the action `show` seems to make usage of `Parameter Conversion` technique, though there is no reference for the `Post` class in that code snippet. I would suggest to replace the parameter `Post $post` to `string $slug` , matching the URL parameter defined above the method `show`.  Commits ------- e35ee1a Inappropriate usage of Parameter Conversion
diff --git a/routing.rst b/routing.rst
@@ -1180,7 +1180,7 @@ the common configuration using options when importing the routes.
             /**
              * @Route("/{_locale}/posts/{slug}", name="show")
              */
-            public function show(Post $post): Response
+            public function show(string $slug): Response
             {
                 // ...
             }

Original file line number	Diff line number	Diff line change
`@@ -1180,7 +1180,7 @@ the common configuration using options when importing the routes.`
`1180`	`1180`	`/**`
`1181`	`1181`	`* @Route("/{_locale}/posts/{slug}", name="show")`
`1182`	`1182`	`*/`
`1183`		`- public function show(Post $post): Response`
	`1183`	`+ public function show(string $slug): Response`
`1184`	`1184`	`{`
`1185`	`1185`	`// ...`
`1186`	`1186`	`}`