minor symfony#12017 [Console] Always use lazy commands (javiereguiluz)

javiereguiluz · javiereguiluz · commit e564caa0ad4f · 2019-07-26T15:04:30.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Console] Always use lazy commands Fixes symfony#8843. Commits ------- 1e50fcf [Console] Always use lazy commands
diff --git a/components/console/changing_default_command.rst b/components/console/changing_default_command.rst
@@ -16,10 +16,11 @@ name to the ``setDefaultCommand()`` method::
 
     class HelloWorldCommand extends Command
     {
+        protected static $defaultName = 'hello:world';
+
         protected function configure()
         {
-            $this->setName('hello:world')
-                ->setDescription('Outputs \'Hello World\'');
+            $this->setDescription('Outputs "Hello World"');
         }
 
         protected function execute(InputInterface $input, OutputInterface $output)
diff --git a/components/console/console_arguments.rst b/components/console/console_arguments.rst
@@ -23,10 +23,11 @@ Have a look at the following command that has three options::
 
     class DemoArgsCommand extends Command
     {
+        protected static $defaultName = 'demo:args';
+
         protected function configure()
         {
             $this
-                ->setName('demo:args')
                 ->setDescription('Describe args behaviors')
                 ->setDefinition(
                     new InputDefinition([
diff --git a/components/console/logger.rst b/components/console/logger.rst
@@ -44,10 +44,11 @@ You can rely on the logger to use this dependency inside a command::
 
     class MyCommand extends Command
     {
+        protected static $defaultName = 'my:command';
+
         protected function configure()
         {
             $this
-                ->setName('my:command')
                 ->setDescription(
                     'Use an external dependency requiring a PSR-3 logger'
                 )
diff --git a/console/commands_as_services.rst b/console/commands_as_services.rst
@@ -35,6 +35,7 @@ For example, suppose you want to log something from within your command::
 
     class SunshineCommand extends Command
     {
+        protected static $defaultName = 'app:sunshine';
         private $logger;
 
         public function __construct(LoggerInterface $logger)
@@ -48,7 +49,6 @@ For example, suppose you want to log something from within your command::
         protected function configure()
         {
             $this
-                ->setName('app:sunshine')
                 ->setDescription('Good morning!');
         }
 
diff --git a/console/hide_commands.rst b/console/hide_commands.rst
@@ -18,10 +18,11 @@ In those cases, you can define the command as **hidden** by setting the
 
     class LegacyCommand extends Command
     {
+        protected static $defaultName = 'app:legacy';
+
         protected function configure()
         {
             $this
-                ->setName('app:legacy')
                 ->setHidden(true)
                 // ...
             ;

Original file line number	Diff line number	Diff line change
@@ -16,10 +16,11 @@ name to the ``setDefaultCommand()`` method::
`16`	`16`
`17`	`17`	`class HelloWorldCommand extends Command`
`18`	`18`	`{`
	`19`	`+ protected static $defaultName = 'hello:world';`
	`20`	`+`
`19`	`21`	`protected function configure()`
`20`	`22`	`{`
`21`		`- $this->setName('hello:world')`
`22`		`- ->setDescription('Outputs \'Hello World\'');`
	`23`	`+ $this->setDescription('Outputs "Hello World"');`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`protected function execute(InputInterface $input, OutputInterface $output)`
Original file line number	Diff line number	Diff line change
`@@ -23,10 +23,11 @@ Have a look at the following command that has three options::`
`23`	`23`
`24`	`24`	`class DemoArgsCommand extends Command`
`25`	`25`	`{`
	`26`	`+ protected static $defaultName = 'demo:args';`
	`27`	`+`
`26`	`28`	`protected function configure()`
`27`	`29`	`{`
`28`	`30`	`$this`
`29`		`- ->setName('demo:args')`
`30`	`31`	`->setDescription('Describe args behaviors')`
`31`	`32`	`->setDefinition(`
`32`	`33`	`new InputDefinition([`
Original file line number	Diff line number	Diff line change
`@@ -44,10 +44,11 @@ You can rely on the logger to use this dependency inside a command::`
`44`	`44`
`45`	`45`	`class MyCommand extends Command`
`46`	`46`	`{`
	`47`	`+ protected static $defaultName = 'my:command';`
	`48`	`+`
`47`	`49`	`protected function configure()`
`48`	`50`	`{`
`49`	`51`	`$this`
`50`		`- ->setName('my:command')`
`51`	`52`	`->setDescription(`
`52`	`53`	`'Use an external dependency requiring a PSR-3 logger'`
`53`	`54`	`)`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ For example, suppose you want to log something from within your command::`
`35`	`35`
`36`	`36`	`class SunshineCommand extends Command`
`37`	`37`	`{`
	`38`	`+ protected static $defaultName = 'app:sunshine';`
`38`	`39`	`private $logger;`
`39`	`40`
`40`	`41`	`public function __construct(LoggerInterface $logger)`
`@@ -48,7 +49,6 @@ For example, suppose you want to log something from within your command::`
`48`	`49`	`protected function configure()`
`49`	`50`	`{`
`50`	`51`	`$this`
`51`		`- ->setName('app:sunshine')`
`52`	`52`	`->setDescription('Good morning!');`
`53`	`53`	`}`
`54`	`54`
Original file line number	Diff line number	Diff line change
`@@ -18,10 +18,11 @@ In those cases, you can define the command as hidden by setting the`
`18`	`18`
`19`	`19`	`class LegacyCommand extends Command`
`20`	`20`	`{`
	`21`	`+ protected static $defaultName = 'app:legacy';`
	`22`	`+`
`21`	`23`	`protected function configure()`
`22`	`24`	`{`
`23`	`25`	`$this`
`24`		`- ->setName('app:legacy')`
`25`	`26`	`->setHidden(true)`
`26`	`27`	`// ...`
`27`	`28`	`;`