fix(49392): show optional class methods with enabled strict option (microsoft#49768)

a-tarasyuk · web-flow · commit 91f7cfc50101 · 2022-07-18T14:49:13.000-07:00
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
@@ -138,7 +138,7 @@ namespace ts.codefix {
                 // If there is more than one overload but no implementation signature
                 // (eg: an abstract method or interface declaration), there is a 1-1
                 // correspondence of declarations and signatures.
-                const signatures = checker.getSignaturesOfType(type, SignatureKind.Call);
+                const signatures = type.isUnion() ? flatMap(type.types, t => t.getCallSignatures()) : type.getCallSignatures();
                 if (!some(signatures)) {
                     break;
                 }
diff --git a/tests/cases/fourslash/completionsOverridingMethod14.ts b/tests/cases/fourslash/completionsOverridingMethod14.ts
@@ -0,0 +1,29 @@
+/// <reference path="fourslash.ts" />
+
+// @Filename: a.ts
+// @strictNullChecks: true
+// @newline: LF
+
+////interface IFoo {
+////    foo?(arg: string): number;
+////}
+////class Foo implements IFoo {
+////    /**/
+////}
+
+verify.completions({
+    marker: "",
+    isNewIdentifierLocation: true,
+    preferences: {
+        includeCompletionsWithInsertText: true,
+        includeCompletionsWithSnippetText: false,
+        includeCompletionsWithClassMemberSnippets: true,
+    },
+    includes: [
+        {
+            name: "foo",
+            sortText: completion.SortText.ClassMemberSnippets,
+            insertText: "foo(arg: string): number {\n}"
+        },
+    ],
+});

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ namespace ts.codefix {`
`138`	`138`	`// If there is more than one overload but no implementation signature`
`139`	`139`	`// (eg: an abstract method or interface declaration), there is a 1-1`
`140`	`140`	`// correspondence of declarations and signatures.`
`141`		`- const signatures = checker.getSignaturesOfType(type, SignatureKind.Call);`
	`141`	`+ const signatures = type.isUnion() ? flatMap(type.types, t => t.getCallSignatures()) : type.getCallSignatures();`
`142`	`142`	`if (!some(signatures)) {`
`143`	`143`	`break;`
`144`	`144`	`}`