fix: nested form options normalization

jacobmllr95 · jacobmllr95 · commit bea039386518 · 2020-04-24T10:55:28.000+02:00
diff --git a/src/components/form-select/helpers/mixin-options.js b/src/components/form-select/helpers/mixin-options.js
@@ -1,5 +1,5 @@
 import get from '../../../utils/get'
-import { isArray, isPlainObject, isUndefined } from '../../../utils/inspect'
+import { isNull, isPlainObject, isUndefined } from '../../../utils/inspect'
 import formOptionsMixin from '../../../mixins/form-options'
 
 // @vue/component
@@ -21,12 +21,12 @@ export default {
       if (isPlainObject(option)) {
         const value = get(option, this.valueField)
         const text = get(option, this.textField)
-        const options = get(option, this.optionsField)
+        const options = get(option, this.optionsField, null)
         // When it has options, create an `<optgroup>` object
-        if (isArray(options)) {
+        if (!isNull(options)) {
           return {
             label: String(get(option, this.labelField) || text),
-            options
+            options: this.normalizeOptions(options)
           }
         }
         // Otherwise create an `<option>` object
diff --git a/src/mixins/form-options.js b/src/mixins/form-options.js
@@ -33,19 +33,7 @@ export default {
   },
   computed: {
     formOptions() {
-      const options = this.options
-      // Normalize the given options array
-      if (isArray(options)) {
-        return options.map(option => this.normalizeOption(option))
-      } else if (isPlainObject(options)) {
-        // Deprecate the object options format
-        warn(OPTIONS_OBJECT_DEPRECATED_MSG, this.$options.name)
-        // Normalize a `options` object to an array of options
-        return keys(options).map(key => this.normalizeOption(options[key] || {}, key))
-      }
-      // If not an array or object, return an empty array
-      /* istanbul ignore next */
-      return []
+      return this.normalizeOptions(this.options)
     }
   },
   methods: {
@@ -67,6 +55,20 @@ export default {
         text: stripTags(String(option)),
         disabled: false
       }
+    },
+    normalizeOptions(options) {
+      // Normalize the given options array
+      if (isArray(options)) {
+        return options.map(option => this.normalizeOption(option))
+      } else if (isPlainObject(options)) {
+        // Deprecate the object options format
+        warn(OPTIONS_OBJECT_DEPRECATED_MSG, this.$options.name)
+        // Normalize a `options` object to an array of options
+        return keys(options).map(key => this.normalizeOption(options[key] || {}, key))
+      }
+      // If not an array or object, return an empty array
+      /* istanbul ignore next */
+      return []
     }
   }
 }
