Skip to content

Commit 3a239fc

Browse files
committed
newer versions, fixes in tests
1 parent 3f13722 commit 3a239fc

File tree

3 files changed

+27
-18
lines changed

3 files changed

+27
-18
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ scalaVersion=2.10.2
2929
gradleVersion=1.6
3030

3131
# The version of Vert.x
32-
vertxVersion=2.1M1
32+
vertxVersion=2.1M2
3333

3434
# The version of Vert.x test tools
3535
toolsVersion=2.0.2-final

src/test/scala/io/vertx/asyncsql/test/BaseSqlTests.scala

Lines changed: 24 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ trait BaseSqlTests { this: SqlTestVerticle =>
3434
expectOk(raw("SELECT 0")) map { reply =>
3535
val res = reply.getArray("results")
3636
assertEquals(1, res.size())
37-
assertEquals(0, res.get[JsonArray](0).get[Int](0))
37+
assertEquals(0, res.get[JsonArray](0).get[Number](0).intValue())
3838
}
3939
}
4040

@@ -43,8 +43,8 @@ trait BaseSqlTests { this: SqlTestVerticle =>
4343
val res = reply.getArray("results")
4444
assertEquals(1, res.size())
4545
val firstElem = res.get[JsonArray](0)
46-
assertEquals(1, firstElem.get[Integer](0))
47-
assertEquals(0, firstElem.get[Integer](1))
46+
assertEquals(1, firstElem.get[Number](0).intValue())
47+
assertEquals(0, firstElem.get[Number](1).intValue())
4848
}
4949
}
5050

@@ -54,7 +54,7 @@ trait BaseSqlTests { this: SqlTestVerticle =>
5454
val receivedFields = reply.getArray("fields")
5555
val results = reply.getArray("results").get[JsonArray](0)
5656

57-
assertEquals(1, reply.getNumber("rows"))
57+
assertEquals(1, reply.getInteger("rows"))
5858

5959
val columnNamesList = receivedFields.asScala.toList
6060

@@ -63,16 +63,16 @@ trait BaseSqlTests { this: SqlTestVerticle =>
6363
assertEquals(15, results.get[Int](columnNamesList.indexOf("age")))
6464
assertTrue(results.get[Any](columnNamesList.indexOf("is_male")) match {
6565
case b: Boolean => b
66-
case i: Int => i == 1
66+
case i: Number => i.intValue() == 1
6767
case x => false
6868
})
69-
assertEquals(167.31, results.get(columnNamesList.indexOf("money")), 0.1)
69+
assertEquals(167.31, results.get[Number](columnNamesList.indexOf("money")).doubleValue(), 0.01)
7070
}
7171
}
7272

7373
def createAndDropTable(): Unit = asyncTest {
7474
createTable("some_test") flatMap (_ => dropTable("some_test")) map { reply =>
75-
assertEquals(0, reply.getNumber("rows"))
75+
assertEquals(0, reply.getInteger("rows"))
7676
}
7777
}
7878

@@ -113,13 +113,14 @@ trait BaseSqlTests { this: SqlTestVerticle =>
113113
assertFieldName("age")
114114
assertFieldName("money")
115115
assertFieldName("wedding_date")
116+
val moneyField = receivedFields.toArray().indexOf("money")
116117

117118
val mrTest = reply.getArray("results").get[JsonArray](0)
118119
assertTrue(mrTest.contains("Mr. Test"))
119120
assertTrue(mrTest.contains("test@example.com"))
120121
assertTrue(mrTest.contains(true) || mrTest.contains(1))
121122
assertTrue(mrTest.contains(15))
122-
assertTrue(mrTest.contains(167.31))
123+
assertEquals(167.31, mrTest.get[Number](moneyField).doubleValue(), 0.0001)
123124
}
124125
}
125126

@@ -130,8 +131,10 @@ trait BaseSqlTests { this: SqlTestVerticle =>
130131
logger.info("received: " + receivedFields.encode())
131132
logger.info("fieldsAr: " + fieldsArray.encode())
132133
checkSameFields(fieldsArray, receivedFields)
134+
logger.info("checked same fields!")
133135
val results = reply.getArray("results")
134136
val mrTest = results.get[JsonArray](0)
137+
logger.info("checking mr test")
135138
checkMrTest(mrTest)
136139
}
137140
}
@@ -149,15 +152,21 @@ trait BaseSqlTests { this: SqlTestVerticle =>
149152
}
150153

151154
private def checkMrTest(mrTest: JsonArray) = {
155+
logger.info("checking mr test name")
152156
assertEquals("Mr. Test", mrTest.get[String](0))
157+
logger.info("checking email")
153158
assertEquals("test@example.com", mrTest.get[String](1))
159+
logger.info("checking is male")
154160
assertTrue(mrTest.get[Any](2) match {
155161
case b: Boolean => b
156-
case i: Int => i == 1
162+
case i: Number => i.intValue() == 1
157163
case x => false
158164
})
159-
assertEquals(15, mrTest.get[Integer](3))
160-
assertEquals(167.31, mrTest.get[Integer](4))
165+
logger.info("checking age")
166+
assertEquals(15, mrTest.get[Number](3).intValue())
167+
logger.info("checking money -> exception?!")
168+
assertEquals(167.31, mrTest.get[Number](4).doubleValue(), 0.0001)
169+
logger.info("checking money -> NO exception?!")
161170
// FIXME check date conversion
162171
// assertEquals("2024-04-01", mrTest.get[JsonObject](5))
163172
}
@@ -166,8 +175,8 @@ trait BaseSqlTests { this: SqlTestVerticle =>
166175
assertEquals("Mrs. Test", mrsTest.get[String](0))
167176
assertEquals("test2@example.com", mrsTest.get[String](1))
168177
assertEquals(false, mrsTest.get[Boolean](2))
169-
assertEquals(43, mrsTest.get[Integer](3))
170-
assertEquals(167.31, mrsTest.get[Integer](4))
178+
assertEquals(43L, mrsTest.get[Long](3))
179+
assertEquals(167.31, mrsTest.get[Number](4).doubleValue(), 0.0001)
171180
// FIXME check date conversion
172181
// assertEquals("1997-12-24", mrsTest.get[JsonObject](5))
173182
}
@@ -212,7 +221,7 @@ trait BaseSqlTests { this: SqlTestVerticle =>
212221
} yield b) map { reply =>
213222
val results = reply.getArray("results")
214223
assertEquals(1, results.size())
215-
assertEquals(21, results.get[JsonArray](0).get[Int](0))
224+
assertEquals(21, results.get[JsonArray](0).get[Number](0).intValue())
216225
}
217226
}
218227

@@ -227,7 +236,7 @@ trait BaseSqlTests { this: SqlTestVerticle =>
227236
} yield b) map { reply =>
228237
val results = reply.getArray("results")
229238
assertEquals(1, results.size())
230-
assertEquals(21, results.get[JsonArray](0).get[Int](0))
239+
assertEquals(21, results.get[JsonArray](0).get[Number](0).intValue())
231240
}
232241
}
233242
}

src/test/scala/io/vertx/asyncsql/test/SqlTestVerticle.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ abstract class SqlTestVerticle extends TestVerticle with BaseVertxIntegrationTes
6565
protected def transaction(statements: JsonObject*) = Json.obj("action" -> "transaction", "statements" -> Json.arr(statements: _*))
6666

6767
protected def createTable(tableName: String) = expectOk(raw(createTableStatement(tableName))) map { reply =>
68-
assertEquals(0, reply.getNumber("rows"))
68+
assertEquals(0, reply.getInteger("rows"))
6969
reply
7070
}
7171

@@ -81,7 +81,7 @@ CREATE TABLE """ + tableName + """ (
8181
email VARCHAR(255) UNIQUE,
8282
is_male BOOLEAN,
8383
age INT,
84-
money FLOAT,
84+
money DOUBLE PRECISION,
8585
wedding_date DATE
8686
);
8787
"""

0 commit comments

Comments
 (0)