fix(git-cmd): use LC_ALL instead of LC_MESSAGES

Byron · Byron · commit 32e4e08cf9cc · 2015-05-31T14:48:47.000+02:00
Previously, only program messages where forced to the C-locale, now we force the entire program. That way, we should assure a remote will not provide us with branch information in any other language but english. Related to #290
diff --git a/git/cmd.py b/git/cmd.py
@@ -530,7 +530,7 @@ def execute(self, command,
             * output_stream if extended_output = False
             * tuple(int(status), output_stream, str(stderr)) if extended_output = True
 
-            Note git is executed with LC_MESSAGES="C" to ensure consitent
+            Note git is executed with LC_MESSAGES="C" to ensure consistent
             output regardless of system language.
 
         :raise GitCommandError:
@@ -549,7 +549,9 @@ def execute(self, command,
 
         # Start the process
         env = os.environ.copy()
-        env["LC_MESSAGES"] = "C"
+        # Attempt to force all output to plain ascii english, which is what some parsing code
+        # may expect.
+        env["LC_ALL"] = "C"
         env.update(self._environment)
 
         if sys.platform == 'win32':
