Add type to symbolicreference.references()

Yobmod · Yobmod · commit 3be955e5adc0 · 2021-07-31T17:53:44.000+01:00
diff --git a/git/refs/head.py b/git/refs/head.py
@@ -40,7 +40,6 @@ def __init__(self, repo: 'Repo', path: PathLike = _HEAD_NAME):
             raise ValueError("HEAD instance must point to %r, got %r" % (self._HEAD_NAME, path))
         super(HEAD, self).__init__(repo, path)
         self.commit: 'Commit'
-        self.ref: 'Head'
 
     def orig_head(self) -> SymbolicReference:
         """
diff --git a/git/refs/symbolic.py b/git/refs/symbolic.py
@@ -26,7 +26,7 @@
 
 if TYPE_CHECKING:
     from git.repo import Repo
-    from git.refs import Head, TagReference, Reference
+    from git.refs import Head, TagReference, RemoteReference, Reference
     from .log import RefLogEntry
     from git.config import GitConfigParser
     from git.objects.commit import Actor
@@ -65,7 +65,6 @@ class SymbolicReference(object):
     def __init__(self, repo: 'Repo', path: PathLike, check_path: bool = False):
         self.repo = repo
         self.path = path
-        self.ref = self.reference
 
     def __str__(self) -> str:
         return str(self.path)
@@ -363,15 +362,8 @@ def set_reference(self, ref: Union[Commit_ish, 'SymbolicReference', str],
         return self
 
     # aliased reference
-    # reference = property(_get_reference, set_reference, doc="Returns the Reference we point to")  # type: ignore
-
-    @property
-    def reference(self) -> 'Reference':
-        return self._get_reference()
-
-    @reference.setter
-    def reference(self, *args, **kwargs):
-        return self.set_reference(*args, **kwargs)
+    reference = property(_get_reference, set_reference, doc="Returns the Reference we point to")  # type: ignore
+    ref: Union['Head', 'TagReference', 'RemoteReference', 'Reference'] = reference             # type: ignore
 
     def is_valid(self) -> bool:
         """
