Skip to content

Commit 3cb5e17

Browse files
committed
doc(cmd): make sure people know wait() may block
Related to #357
1 parent ec401e4 commit 3cb5e17

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

git/cmd.py

+2
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import threading
1313
import errno
1414
import mmap
15+
import warnings
1516

1617
from contextlib import contextmanager
1718
from subprocess import (
@@ -309,6 +310,7 @@ def __getattr__(self, attr):
309310
def wait(self):
310311
"""Wait for the process and return its status code.
311312
313+
:warn: may deadlock if output or error pipes are used and not handled separately.
312314
:raise GitCommandError: if the return status is not 0"""
313315
status = self.proc.wait()
314316
if status != 0:

0 commit comments

Comments
 (0)