fix(repo): Use GIT_DIR only if no repo-path given

ankostis · ankostis · commit 5fac8d40f535 · 2016-10-22T13:27:44.000+02:00
FIX #535 according to Byron's comment: #535 (comment)
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -100,8 +100,8 @@ def __init__(self, path=None, odbt=DefaultDBType, search_parent_directories=Fals
                 repo = Repo("$REPOSITORIES/Development/git-python.git")
 
             - In *Cygwin*, path may be a `'cygdrive/...'` prefixed path.
-            - If `None, current-directory is used.
-            - The :envvar:`GIT_DIR` if set and not empty takes precendance over this parameter.
+            - If it evaluates to false, :envvar:`GIT_DIR` is used, and if this also evals to false,
+              the current-directory is used.
         :param odbt:
             Object DataBase type - a type which is constructed by providing
             the directory containing the database objects, i.e. .git/objects. It will
@@ -114,7 +114,9 @@ def __init__(self, path=None, odbt=DefaultDBType, search_parent_directories=Fals
         :raise InvalidGitRepositoryError:
         :raise NoSuchPathError:
         :return: git.Repo """
-        epath = os.getenv('GIT_DIR') or path or os.getcwd()
+        epath = path or os.getenv('GIT_DIR')
+        if not epath:
+            epath = os.getcwd()
         if Git.is_cygwin():
             epath = decygpath(epath)
         epath = _expand_path(epath or path or os.getcwd())
