Add types to Remote. init getattr exists

Yobmod · Yobmod · commit 6a2f5d05f4a8 · 2021-05-08T16:37:23.000+01:00
diff --git a/git/remote.py b/git/remote.py
@@ -433,15 +433,15 @@ class Remote(LazyMixin, Iterable):
     __slots__ = ("repo", "name", "_config_reader")
     _id_attribute_ = "name"
 
-    def __init__(self, repo, name):
+    def __init__(self, repo: 'Repo', name: str) -> None:
         """Initialize a remote instance
 
         :param repo: The repository we are a remote of
         :param name: the name of the remote, i.e. 'origin'"""
         self.repo = repo  # type: 'Repo'
         self.name = name
 
-    def __getattr__(self, attr):
+    def __getattr__(self, attr: str) -> Any:
         """Allows to call this instance like
         remote.special( \\*args, \\*\\*kwargs) to call git-remote special self.name"""
         if attr == "_config_reader":
@@ -481,7 +481,7 @@ def __ne__(self, other):
     def __hash__(self):
         return hash(self.name)
 
-    def exists(self):
+    def exists(self) -> bool:
         """
         :return: True if this is a valid, existing remote.
             Valid remotes have an entry in the repository's configuration"""
diff --git a/mypy.ini b/mypy.ini
@@ -2,7 +2,7 @@
 [mypy]
 
 # TODO: enable when we've fully annotated everything
-#disallow_untyped_defs = True
+disallow_untyped_defs = True
 
 # TODO: remove when 'gitdb' is fully annotated
 [mypy-gitdb.*]
