improvement(mypy): ignore false positives

muggenhor · muggenhor · commit 76ba0924be14 · 2021-04-23T15:23:11.000+02:00
diff --git a/git/cmd.py b/git/cmd.py
@@ -138,7 +138,7 @@ def dict_to_slots_and__excluded_are_none(self, d, excluded=()):
 
 ## CREATE_NEW_PROCESS_GROUP is needed to allow killing it afterwards,
 # see https://docs.python.org/3/library/subprocess.html#subprocess.Popen.send_signal
-PROC_CREATIONFLAGS = (CREATE_NO_WINDOW | subprocess.CREATE_NEW_PROCESS_GROUP
+PROC_CREATIONFLAGS = (CREATE_NO_WINDOW | subprocess.CREATE_NEW_PROCESS_GROUP  # type: ignore[attr-defined]
                       if is_win else 0)
 
 
diff --git a/git/config.py b/git/config.py
@@ -216,7 +216,7 @@ def get_config_path(config_level: Literal['system', 'global', 'user', 'repositor
     raise ValueError("Invalid configuration level: %r" % config_level)
 
 
-class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser, object)):
+class GitConfigParser(with_metaclass(MetaParserBuilder, cp.RawConfigParser, object)):  # type: ignore ## mypy does not understand dynamic class creation # noqa: E501
 
     """Implements specifics required to read git style configuration files.
 
diff --git a/git/refs/reference.py b/git/refs/reference.py
@@ -103,7 +103,7 @@ def iter_items(cls, repo, common_path=None):
 
     #{ Remote Interface
 
-    @property
+    @property  # type: ignore ## mypy cannot deal with properties with an extra decorator (2021-04-21)
     @require_remote_ref_path
     def remote_name(self):
         """
@@ -114,7 +114,7 @@ def remote_name(self):
         # /refs/remotes/<remote name>/<branch_name>
         return tokens[2]
 
-    @property
+    @property  # type: ignore ## mypy cannot deal with properties with an extra decorator (2021-04-21)
     @require_remote_ref_path
     def remote_head(self):
         """:return: Name of the remote head itself, i.e. master.
