Remove some unneeded mypy suppressions

EliahKagan · EliahKagan · commit 84fc8062dccb · 2024-03-09T19:21:11.000-05:00
These include suppressions that are no longer required because they
worked around mypy bugs that have been fixed, or because they were
not actually effective. It may also include some that are no longer
needed becuase of improvements made to GitPython's type annotations
(or other code) since they were introduced, I am not sure.

This deliberately keeps warn_unused_ignores uncommented in
pyproject.toml, at least for now.
diff --git a/git/config.py b/git/config.py
@@ -344,9 +344,9 @@ def __init__(
             configuration files.
         """
         cp.RawConfigParser.__init__(self, dict_type=_OMD)
-        self._dict: Callable[..., _OMD]  # type: ignore   # mypy/typeshed bug?
+        self._dict: Callable[..., _OMD]
         self._defaults: _OMD
-        self._sections: _OMD  # type: ignore  # mypy/typeshed bug?
+        self._sections: _OMD
 
         # Used in Python 3. Needs to stay in sync with sections for underlying
         # implementation to work.
diff --git a/git/objects/commit.py b/git/objects/commit.py
@@ -292,7 +292,7 @@ def name_rev(self) -> str:
     def iter_items(
         cls,
         repo: "Repo",
-        rev: Union[str, "Commit", "SymbolicReference"],  # type: ignore
+        rev: Union[str, "Commit", "SymbolicReference"],
         paths: Union[PathLike, Sequence[PathLike]] = "",
         **kwargs: Any,
     ) -> Iterator["Commit"]:
diff --git a/git/objects/tree.py b/git/objects/tree.py
@@ -300,7 +300,7 @@ def cache(self) -> TreeModifier:
         return TreeModifier(self._cache)
 
     def traverse(
-        self,  # type: ignore[override]
+        self,
         predicate: Callable[[Union[IndexObjUnion, TraversedTreeTup], int], bool] = lambda i, d: True,
         prune: Callable[[Union[IndexObjUnion, TraversedTreeTup], int], bool] = lambda i, d: False,
         depth: int = -1,
@@ -331,7 +331,7 @@ def traverse(
             super()._traverse(
                 predicate,
                 prune,
-                depth,  # type: ignore
+                depth,
                 branch_first,
                 visit_once,
                 ignore_self,
diff --git a/git/objects/util.py b/git/objects/util.py
@@ -619,7 +619,7 @@ class TraversableIterableObj(IterableObj, Traversable):
     def list_traverse(self: T_TIobj, *args: Any, **kwargs: Any) -> IterableList[T_TIobj]:
         return super()._list_traverse(*args, **kwargs)
 
-    @overload  # type: ignore
+    @overload
     def traverse(self: T_TIobj) -> Iterator[T_TIobj]:
         ...
 
diff --git a/git/refs/reference.py b/git/refs/reference.py
@@ -150,7 +150,7 @@ def iter_items(
 
     # { Remote Interface
 
-    @property  # type: ignore  # mypy cannot deal with properties with an extra decorator (2021-04-21).
+    @property
     @require_remote_ref_path
     def remote_name(self) -> str:
         """
@@ -162,7 +162,7 @@ def remote_name(self) -> str:
         # /refs/remotes/<remote name>/<branch_name>
         return tokens[2]
 
-    @property  # type: ignore  # mypy cannot deal with properties with an extra decorator (2021-04-21).
+    @property
     @require_remote_ref_path
     def remote_head(self) -> str:
         """
diff --git a/git/util.py b/git/util.py
@@ -510,8 +510,8 @@ def expand_path(p: Union[None, PathLike], expand_vars: bool = True) -> Optional[
     try:
         p = osp.expanduser(p)  # type: ignore
         if expand_vars:
-            p = osp.expandvars(p)  # type: ignore
-        return osp.normpath(osp.abspath(p))  # type: ignore
+            p = osp.expandvars(p)
+        return osp.normpath(osp.abspath(p))
     except Exception:
         return None
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -24,7 +24,7 @@ python_version = "3.8"
 disallow_untyped_defs = true
 no_implicit_optional = true
 warn_redundant_casts = true
-# warn_unused_ignores = true
+warn_unused_ignores = true
 warn_unreachable = true
 show_error_codes = true
 implicit_reexport = true
