Expand to test top-level deprecated names

EliahKagan · EliahKagan · commit 859e38cfb395 · 2024-03-28T22:44:57.000-04:00
diff --git a/test/deprecation/test_attributes.py b/test/deprecation/test_attributes.py
@@ -1,5 +1,7 @@
 """Tests for dynamic and static attribute errors."""
 
+import importlib
+
 import pytest
 
 
@@ -12,4 +14,89 @@ def test_cannot_get_undefined() -> None:
 
 def test_cannot_import_undefined() -> None:
     with pytest.raises(ImportError):
-        from git import foo
+        from git import foo  # noqa: F401
+
+
+def test_util_alias_access_resolves() -> None:
+    """These resolve for now, though they're private we do not guarantee this."""
+    import git
+
+    assert git.util is git.index.util
+
+
+def test_util_alias_import_resolves() -> None:
+    from git import util
+    import git
+
+    util is git.index.util
+
+
+def test_util_alias_access_warns() -> None:
+    import git
+
+    with pytest.deprecated_call() as ctx:
+        git.util
+
+    assert len(ctx) == 1
+    message = ctx[0].message.args[0]
+    assert "git.util" in message
+    assert "git.index.util" in message
+    assert "should not be relied on" in message
+
+
+def test_util_alias_import_warns() -> None:
+    with pytest.deprecated_call() as ctx:
+        from git import util  # noqa: F401
+
+    message = ctx[0].message.args[0]
+    assert "git.util" in message
+    assert "git.index.util" in message
+    assert "should not be relied on" in message
+
+
+_parametrize_by_private_alias = pytest.mark.parametrize(
+    "name, fullname",
+    [
+        ("head", "git.refs.head"),
+        ("log", "git.refs.log"),
+        ("reference", "git.refs.reference"),
+        ("symbolic", "git.refs.symbolic"),
+        ("tag", "git.refs.tag"),
+        ("base", "git.index.base"),
+        ("fun", "git.index.fun"),
+        ("typ", "git.index.typ"),
+    ],
+)
+
+
+@_parametrize_by_private_alias
+def test_private_module_alias_access_resolves(name: str, fullname: str) -> None:
+    """These resolve for now, though they're private we do not guarantee this."""
+    import git
+
+    assert getattr(git, name) is importlib.import_module(fullname)
+
+
+@_parametrize_by_private_alias
+def test_private_module_alias_import_resolves(name: str, fullname: str) -> None:
+    exec(f"from git import {name}")
+    locals()[name] is importlib.import_module(fullname)
+
+
+@_parametrize_by_private_alias
+def test_private_module_alias_access_warns(name: str, fullname: str) -> None:
+    import git
+
+    with pytest.deprecated_call() as ctx:
+        getattr(git, name)
+
+    assert len(ctx) == 1
+    assert ctx[0].message.args[0].endswith(f"Use {fullname} instead.")
+
+
+@_parametrize_by_private_alias
+def test_private_module_alias_import_warns(name: str, fullname: str) -> None:
+    with pytest.deprecated_call() as ctx:
+        exec(f"from git import {name}")
+
+    assert ctx[0].message.args[0].endswith(f"Use {fullname} instead.")
