Test TypedDict in repo.base.blame() 1

Yobmod · Yobmod · commit e4761ff67ef1 · 2021-08-02T22:45:19.000+01:00
diff --git a/git/repo/base.py b/git/repo/base.py
@@ -909,7 +909,7 @@ class InfoTD(TypedDict, total=False):
                 line_str = line_bytes.rstrip().decode(defenc)
             except UnicodeDecodeError:
                 firstpart = ''
-                parts = ['']
+                parts = []
                 is_binary = True
             else:
                 # As we don't have an idea when the binary data ends, as it could contain multiple newlines
@@ -983,20 +983,21 @@ class InfoTD(TypedDict, total=False):
                                     info['committer'] + ' ' + info['committer_email']),
                                     committed_date=info['committer_date'])
                                 commits[sha] = c
-                                blames[-1][0] = c
+                            blames[-1][0] = c
                             # END if commit objects needs initial creation
+                            if not is_binary:
+                                if line_str and line_str[0] == '\t':
+                                    line_str = line_str[1:]
+                            else:
+                                pass
+                                # NOTE: We are actually parsing lines out of binary data, which can lead to the
+                                # binary being split up along the newline separator. We will append this to the
+                                # blame we are currently looking at, even though it should be concatenated with
+                                # the last line we have seen.
+
                             if blames[-1][1] is not None:
-                                if not is_binary:
-                                    if line_str and line_str[0] == '\t':
-                                        line_str = line_str[1:]
-
-                                    blames[-1][1].append(line_str)
-                                else:
-                                    # NOTE: We are actually parsing lines out of binary data, which can lead to the
-                                    # binary being split up along the newline separator. We will append this to the
-                                    # blame we are currently looking at, even though it should be concatenated with
-                                    # the last line we have seen.
-                                    blames[-1][1].append(line_bytes)
+                                blames[-1][1].append(line_str)
+                            info = {'id': sha}
                             # end handle line contents
 
                             info = {'id': sha}
