Add type to symbolicreference.set_reference()

Yobmod · Yobmod · commit e8442eead72b · 2021-07-31T17:15:33.000+01:00
diff --git a/git/refs/symbolic.py b/git/refs/symbolic.py
@@ -289,7 +289,8 @@ def _get_reference(self):
             raise TypeError("%s is a detached symbolic reference as it points to %r" % (self, sha))
         return self.from_path(self.repo, target_ref_path)
 
-    def set_reference(self, ref, logmsg=None):
+    def set_reference(self, ref: Union[Commit_ish, 'SymbolicReference', str],
+                      logmsg: Union[str, None] = None) -> Union[Commit_ish, 'SymbolicReference']:
         """Set ourselves to the given ref. It will stay a symbol if the ref is a Reference.
         Otherwise an Object, given as Object instance or refspec, is assumed and if valid,
         will be set which effectively detaches the refererence if it was a purely
@@ -330,7 +331,7 @@ def set_reference(self, ref, logmsg=None):
             raise TypeError("Require commit, got %r" % obj)
         # END verify type
 
-        oldbinsha = None
+        oldbinsha: bytes = b''
         if logmsg is not None:
             try:
                 oldbinsha = self.commit.binsha
@@ -359,8 +360,8 @@ def set_reference(self, ref, logmsg=None):
         return self
 
     # aliased reference
-    reference = property(_get_reference, set_reference, doc="Returns the Reference we point to")
-    ref: Union['Reference'] = reference     # type: ignore
+    reference = property(_get_reference, set_reference, doc="Returns the Reference we point to")  # type: ignore
+    ref: Union['Reference'] = reference             # type: ignore
 
     def is_valid(self) -> bool:
         """
