Skip to content

Fix single cone graph #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2018
Merged

Fix single cone graph #9

merged 2 commits into from
May 20, 2018

Conversation

kig
Copy link
Collaborator

@kig kig commented May 20, 2018

Fix for #8 - a mix of fixing a number of false assumptions.

Fixes for:

  • Scaling of cones went to infinite with single-cone graphs.
  • Cone offset default wasn't respected because cone.js generated coneOffset: undefined as its output.

Also:

  • Refactored maxLen to maxNorm to avoid confusion.
  • Added single cone example

@kig kig merged commit d3079a5 into master May 20, 2018
@kig kig deleted the fix-single-cone-graph branch May 20, 2018 03:49
@etpinard
Copy link
Member

Great. Thanks!

I just published v1.0.1 to https://www.npmjs.com/package/gl-cone3d

What's your npm username so that I can add as contributor on npm?

@etpinard etpinard mentioned this pull request May 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kig @etpinard