Skip to content

Commit f6d450e

Browse files
committed
[Toolkit.Game] Fix issue sharpdx#400. Improve stability of EffectCompilerSystem, by allowing concurrent read/write on dependency/shader files.
1 parent 7856ad0 commit f6d450e

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Source/Toolkit/SharpDX.Toolkit.Compiler/EffectCompilerInternal.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,8 @@ public bool CheckForChanges(string dependencyFilePath)
9494
/// <param name="flags">The flags.</param>
9595
/// <param name="macros">The macrosArgs.</param>
9696
/// <param name="includeDirectoryList">The include directory list.</param>
97-
/// <param name="includeFileDelegate">The include file delegate.</param>
97+
/// <param name="alloDynamicCompiling">if set to <c>true</c> [allo dynamic compiling].</param>
98+
/// <param name="dependencyFilePath">The dependency file path.</param>
9899
/// <returns>The result of compilation.</returns>
99100
public EffectCompilerResult CompileFromFile(string filePath, EffectCompilerFlags flags = EffectCompilerFlags.None, List<EffectData.ShaderMacro> macros = null, List<string> includeDirectoryList = null, bool alloDynamicCompiling = false, string dependencyFilePath = null)
100101
{
@@ -109,7 +110,8 @@ public EffectCompilerResult CompileFromFile(string filePath, EffectCompilerFlags
109110
/// <param name="flags">The flags.</param>
110111
/// <param name="macrosArgs">The macrosArgs.</param>
111112
/// <param name="includeDirectoryList">The include directory list.</param>
112-
/// <param name="includeFileDelegate">The include file delegate.</param>
113+
/// <param name="allowDynamicCompiling">if set to <c>true</c> [allow dynamic compiling].</param>
114+
/// <param name="dependencyFilePath">The dependency file path.</param>
113115
/// <returns>The result of compilation.</returns>
114116
public EffectCompilerResult Compile(string sourceCode, string filePath, EffectCompilerFlags flags = EffectCompilerFlags.None, List<EffectData.ShaderMacro> macrosArgs = null, List<string> includeDirectoryList = null, bool allowDynamicCompiling = false, string dependencyFilePath = null)
115117
{

0 commit comments

Comments
 (0)