git: stop iterating at oldest shallow when pulling. Fixes #305 #939

dhoizner · 2023-11-22T18:09:49Z

The CommitPreorderIter created to check whether two given commits are fast-forwardable was trying to iterate beyond the first commit of a shallow clone, this was causing object not found errors when trying to pull down new changes from the remote on a shallow clone.

This pull solves that by passing in an optional parameter specifying the earliest shallow commit and instructing the iterator to stop before trying to visit that commit's parents.

Note: this will work for Pulls that don't specify depth or a Pull with a specified depth that is greater than or equal to the number of new commits on the remote. This means that the following scenario will still fail:

clone with depth 1
push two new commits to the remote ref
pull with depth 1

If instead of pulling with depth 1 in the above scenario, the user were to pull with a depth of 2 or an unspecified depth, the pull would succeed.

dhoizner · 2023-11-22T23:43:26Z

i think the check failure here might be flaky tests, i had to run the test suite a couple of times locally before everything passed (with -count=1 to ensure that cached results weren't being reused)

pjbgf · 2023-11-23T10:15:22Z

@dhoizner based on your comment, I am assuming the test for this could very similar to

go-git/remote_test.go

Line 1497 in fecea41

func (s *RemoteSuite) TestFetchAfterShallowClone(c *C) {

with slight tweaks.

I am not sure we need a new fixture for this, but if you think we do, here's how to create new ones.

dhoizner · 2023-11-23T16:36:13Z

@dhoizner based on your comment, I am assuming the test for this could very similar to

go-git/remote_test.go

Line 1497 in fecea41

func (s *RemoteSuite) TestFetchAfterShallowClone(c *C) {

with slight tweaks.

I am not sure we need a new fixture for this, but if you think we do, here's how to create new ones.

Sweet, I was thinking that something like the fetch after shallow test would work also but wasn't sure if we'd want the tests to use fixtures like the rest of the worktree tests.

I'll get that done in the next few days.

dhoizner · 2023-11-26T01:37:01Z

@pjbgf added a test and a comment about a failure mode that will continue to exist, as well as updating the pull description explaining that failure mode. I think this is still worth merging in as is, with an issue to track the other scenario, but am open to suggestions

pjbgf

@dhoizner thanks for working on this. 🥇

Tang8330 · 2023-12-01T16:59:56Z

Just wanted to say thank you for this fix @dhoizner !

ffhan · 2023-12-08T11:13:26Z

@dhoizner thank you for this fix!

One thing to note, though (minimal example to reproduce below):

clone with depth 1
push two new commits to the remote ref
pull with depth 1
If instead of pulling with depth 1 in the above scenario, the user were to pull with a depth of 2 or an unspecified depth, the pull would succeed.

If Depth for pulling is not specified this does not work. It is necessary to set it to a value above 1 to make this work.

package main

import (
	"bufio"
	"context"
	"fmt"
	"github.com/go-git/go-git/v5"
	"github.com/go-git/go-git/v5/plumbing/transport/ssh"
	ssh2 "golang.org/x/crypto/ssh"
	"os"
	"os/signal"
)

func main() {
	if stat, err := os.Stat("./repos/testing"); err == nil && stat.IsDir() {
		if err := os.RemoveAll("./repos/testing"); err != nil {
			panic(err)
		}
	}
	ctx, stop := signal.NotifyContext(context.Background(), os.Interrupt)
	defer stop()

	keys, err := ssh.NewPublicKeysFromFile("git", "/Users/<user>/.ssh/id_rsa", "<password>")
	if err != nil {
		panic(err)
	}
	keys.HostKeyCallback = ssh2.InsecureIgnoreHostKey()

	repo, err := git.PlainCloneContext(ctx, "./repos/testing", false, &git.CloneOptions{
		URL:           "github.com:<user>/testing.git",
		SingleBranch:  true,
		ReferenceName: "refs/heads/main",
		Auth:          keys,
		Depth:         1,
	})
	if err != nil {
		panic(err)
	}
	fmt.Println("cloned")

	reader := bufio.NewReader(os.Stdin)
	for {
		fmt.Printf("newline to pull, exit to exit")
		// in the meantime commit and push to the repo so there's smth to pull
		line, _, err := reader.ReadLine()
		if err != nil {
			panic(err)
		}
		if string(line) == "exit" {
			return
		}
		tree, err := repo.Worktree()
		if err != nil {
			panic(err)
		}
		fmt.Println("pulling")
		if err = tree.PullContext(ctx, &git.PullOptions{
			Auth: keys,
			//Depth:         100000,
			SingleBranch:  true,
			ReferenceName: "refs/heads/main",
			Force:         true,
		}); err != nil {
			panic(err)
		}
	}
}

Runtime (with depth not set):

$ go run ./minimal
cloned
newline to pull, exit to exit
pulling
panic: object not found

runtime (with Depth: 10000 in PullContext):

$ go run ./minimal
cloned
newline to pull, exit to exit
pulling
newline to pull, exit to exit^Cexit

In both examples between cloning and pulling I pushed a commit (tested this with multiple commits as well, same behaviour).

This should either be documented or fixed - I couldn't really figure out why this happens, nor why setting a depth to a big number fixes it. Are there any potential drawbacks to setting Depth when pulling? Especially for big repositories with a lot of commits.

dhoizner · 2023-12-08T15:45:32Z

hi @ffhan thanks for trying it out! unfortunately, I wasn't able to reproduce with your example :/

Code and output are in this gist

Can you make sure that you're referencing a version of go-git that includes this pull?

go get github.com/go-git/go-git/v5@master will pull the current HEAD from master

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | require | minor | `v5.10.1` -> `v5.11.0` | --- ### Release Notes <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.11.0`](https://togithub.com/go-git/go-git/releases/tag/v5.11.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.10.1...v5.11.0) #### What's Changed - git: validate reference names ([#929](https://togithub.com/go-git/go-git/issues/929)) by [@aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/950](https://togithub.com/go-git/go-git/pull/950) - git: stop iterating at oldest shallow when pulling. Fixes [#305](https://togithub.com/go-git/go-git/issues/305) by [@dhoizner](https://togithub.com/dhoizner) in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - plumbing: object, enable renames in getFileStatsFromFilePatches by [@djmoch](https://togithub.com/djmoch) in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) - storage: filesystem, Add option to set a specific FS for alternates by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/953](https://togithub.com/go-git/go-git/pull/953) - Align worktree validation with upstream and remove build warnings by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/958](https://togithub.com/go-git/go-git/pull/958) #### New Contributors - [@dhoizner](https://togithub.com/dhoizner) made their first contribution in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - [@djmoch](https://togithub.com/djmoch) made their first contribution in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) **Full Changelog**: go-git/go-git@v5.10.1...v5.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/anoriqq/qpm).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…rity] (#721) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | `v5.10.1` -> `v5.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-49568](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) ### Impact A denial of service (DoS) vulnerability was discovered in go-git versions prior to `v5.11`. This vulnerability allows an attacker to perform denial of service attacks by providing specially crafted responses from a Git server which triggers resource exhaustion in `go-git` clients. Applications using only the in-memory filesystem supported by `go-git` are not affected by this vulnerability. This is a `go-git` implementation issue and does not affect the upstream `git` cli. ### Patches Users running versions of `go-git` from `v4` and above are recommended to upgrade to `v5.11` in order to mitigate this vulnerability. ### Workarounds In cases where a bump to the latest version of `go-git` is not possible, we recommend limiting its use to only trust-worthy Git servers. ## Credit Thanks to Ionut Lalu for responsibly disclosing this vulnerability to us. ### References - [GHSA-mw99-9chc-xw7r](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) --- ### Release Notes <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.11.0`](https://togithub.com/go-git/go-git/releases/tag/v5.11.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.10.1...v5.11.0) #### What's Changed - git: validate reference names ([#929](https://togithub.com/go-git/go-git/issues/929)) by [@aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/950](https://togithub.com/go-git/go-git/pull/950) - git: stop iterating at oldest shallow when pulling. Fixes [#305](https://togithub.com/go-git/go-git/issues/305) by [@dhoizner](https://togithub.com/dhoizner) in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - plumbing: object, enable renames in getFileStatsFromFilePatches by [@djmoch](https://togithub.com/djmoch) in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) - storage: filesystem, Add option to set a specific FS for alternates by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/953](https://togithub.com/go-git/go-git/pull/953) - Align worktree validation with upstream and remove build warnings by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/958](https://togithub.com/go-git/go-git/pull/958) #### New Contributors - [@dhoizner](https://togithub.com/dhoizner) made their first contribution in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - [@djmoch](https://togithub.com/djmoch) made their first contribution in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) **Full Changelog**: go-git/go-git@v5.10.1...v5.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv-scanner).

…ntainerd/containerd to v1.7.11 [security] (#2209) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | `v5.10.1` -> `v5.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. ### GitHub Vulnerability Alerts #### [CVE-2023-49568](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) ### Impact A denial of service (DoS) vulnerability was discovered in go-git versions prior to `v5.11`. This vulnerability allows an attacker to perform denial of service attacks by providing specially crafted responses from a Git server which triggers resource exhaustion in `go-git` clients. Applications using only the in-memory filesystem supported by `go-git` are not affected by this vulnerability. This is a `go-git` implementation issue and does not affect the upstream `git` cli. ### Patches Users running versions of `go-git` from `v4` and above are recommended to upgrade to `v5.11` in order to mitigate this vulnerability. ### Workarounds In cases where a bump to the latest version of `go-git` is not possible, we recommend limiting its use to only trust-worthy Git servers. ## Credit Thanks to Ionut Lalu for responsibly disclosing this vulnerability to us. ### References - [GHSA-mw99-9chc-xw7r](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) --- ### Release Notes <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.11.0`](https://togithub.com/go-git/go-git/releases/tag/v5.11.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.10.1...v5.11.0) #### What's Changed - git: validate reference names ([#929](https://togithub.com/go-git/go-git/issues/929)) by [@aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/950](https://togithub.com/go-git/go-git/pull/950) - git: stop iterating at oldest shallow when pulling. Fixes [#305](https://togithub.com/go-git/go-git/issues/305) by [@dhoizner](https://togithub.com/dhoizner) in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - plumbing: object, enable renames in getFileStatsFromFilePatches by [@djmoch](https://togithub.com/djmoch) in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) - storage: filesystem, Add option to set a specific FS for alternates by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/953](https://togithub.com/go-git/go-git/pull/953) - Align worktree validation with upstream and remove build warnings by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/958](https://togithub.com/go-git/go-git/pull/958) #### New Contributors - [@dhoizner](https://togithub.com/dhoizner) made their first contribution in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - [@djmoch](https://togithub.com/djmoch) made their first contribution in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) **Full Changelog**: go-git/go-git@v5.10.1...v5.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/zarf).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Wayne Starr <me@racer159.com>

…rity] (#1891) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/go-git/go-git/v5](https://togithub.com/go-git/go-git) | `v5.10.1` -> `v5.11.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fgo-git%2fgo-git%2fv5/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fgo-git%2fgo-git%2fv5/v5.10.1/v5.11.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | ### GitHub Vulnerability Alerts #### [CVE-2023-49568](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) ### Impact A denial of service (DoS) vulnerability was discovered in go-git versions prior to `v5.11`. This vulnerability allows an attacker to perform denial of service attacks by providing specially crafted responses from a Git server which triggers resource exhaustion in `go-git` clients. Applications using only the in-memory filesystem supported by `go-git` are not affected by this vulnerability. This is a `go-git` implementation issue and does not affect the upstream `git` cli. ### Patches Users running versions of `go-git` from `v4` and above are recommended to upgrade to `v5.11` in order to mitigate this vulnerability. ### Workarounds In cases where a bump to the latest version of `go-git` is not possible, we recommend limiting its use to only trust-worthy Git servers. ## Credit Thanks to Ionut Lalu for responsibly disclosing this vulnerability to us. ### References - [GHSA-mw99-9chc-xw7r](https://togithub.com/go-git/go-git/security/advisories/GHSA-mw99-9chc-xw7r) --- ### Release Notes <details> <summary>go-git/go-git (github.com/go-git/go-git/v5)</summary> ### [`v5.11.0`](https://togithub.com/go-git/go-git/releases/tag/v5.11.0) [Compare Source](https://togithub.com/go-git/go-git/compare/v5.10.1...v5.11.0) #### What's Changed - git: validate reference names ([#929](https://togithub.com/go-git/go-git/issues/929)) by [@aymanbagabas](https://togithub.com/aymanbagabas) in [https://github.com/go-git/go-git/pull/950](https://togithub.com/go-git/go-git/pull/950) - git: stop iterating at oldest shallow when pulling. Fixes [#305](https://togithub.com/go-git/go-git/issues/305) by [@dhoizner](https://togithub.com/dhoizner) in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - plumbing: object, enable renames in getFileStatsFromFilePatches by [@djmoch](https://togithub.com/djmoch) in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) - storage: filesystem, Add option to set a specific FS for alternates by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/953](https://togithub.com/go-git/go-git/pull/953) - Align worktree validation with upstream and remove build warnings by [@pjbgf](https://togithub.com/pjbgf) in [https://github.com/go-git/go-git/pull/958](https://togithub.com/go-git/go-git/pull/958) #### New Contributors - [@dhoizner](https://togithub.com/dhoizner) made their first contribution in [https://github.com/go-git/go-git/pull/939](https://togithub.com/go-git/go-git/pull/939) - [@djmoch](https://togithub.com/djmoch) made their first contribution in [https://github.com/go-git/go-git/pull/941](https://togithub.com/go-git/go-git/pull/941) **Full Changelog**: go-git/go-git@v5.10.1...v5.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "" in timezone Australia/Sydney, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/google/osv.dev).

git: stop iterating at oldest shallow when pulling. Fixes go-git#305

pjbgf added this to the v5.11.0 milestone Nov 23, 2023

dhoizner force-pushed the fix-pull-after-shallow branch from 3f80b0a to b74ae19 Compare November 26, 2023 01:42

git: stop iterating at oldest shallow when pulling. Fixes go-git#305

861009f

dhoizner force-pushed the fix-pull-after-shallow branch from b74ae19 to 861009f Compare November 27, 2023 16:09

pjbgf approved these changes Dec 1, 2023

View reviewed changes

pjbgf merged commit ae552ce into go-git:master Dec 1, 2023

traidare pushed a commit to traidare/go-git that referenced this pull request Oct 26, 2024

Merge pull request go-git#939 from dhoizner/fix-pull-after-shallow

c3a6c47

git: stop iterating at oldest shallow when pulling. Fixes go-git#305

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

git: stop iterating at oldest shallow when pulling. Fixes #305 #939

git: stop iterating at oldest shallow when pulling. Fixes #305 #939

dhoizner commented Nov 22, 2023 •

edited

Loading

dhoizner commented Nov 22, 2023

pjbgf commented Nov 23, 2023

dhoizner commented Nov 23, 2023

dhoizner commented Nov 26, 2023

pjbgf left a comment

Tang8330 commented Dec 1, 2023

ffhan commented Dec 8, 2023 •

edited

Loading

dhoizner commented Dec 8, 2023

git: stop iterating at oldest shallow when pulling. Fixes #305 #939

git: stop iterating at oldest shallow when pulling. Fixes #305 #939

Conversation

dhoizner commented Nov 22, 2023 • edited Loading

dhoizner commented Nov 22, 2023

pjbgf commented Nov 23, 2023

dhoizner commented Nov 23, 2023

dhoizner commented Nov 26, 2023

pjbgf left a comment

Choose a reason for hiding this comment

Tang8330 commented Dec 1, 2023

ffhan commented Dec 8, 2023 • edited Loading

dhoizner commented Dec 8, 2023

dhoizner commented Nov 22, 2023 •

edited

Loading

ffhan commented Dec 8, 2023 •

edited

Loading