langserver: Extension to limit returned references (sourcegraph#106)

keegancsmith · web-flow · commit 9dc79a89aabd · 2017-01-23T20:03:26.000+02:00
diff --git a/langserver/references.go b/langserver/references.go
@@ -164,6 +164,15 @@ func (h *LangHandler) handleTextDocumentReferences(ctx context.Context, conn JSO
 
 	locs := goRangesToLSPLocations(fset, refs)
 	sortBySharedDirWithURI(params.TextDocument.URI, locs)
+
+	// Technically we may be able to stop computing references sooner and
+	// save RAM/CPU, but currently that would have two drawbacks:
+	// * We can't stop the typechecking anyways
+	// * We may return results that are not as interesting since sortBySharedDirWithURI won't see everything.
+	if params.Context.XLimit > 0 && params.Context.XLimit < len(locs) {
+		locs = locs[:params.Context.XLimit]
+	}
+
 	return locs, nil
 }
 
diff --git a/pkg/lsp/service.go b/pkg/lsp/service.go
@@ -156,6 +156,9 @@ type ParameterInformation struct {
 
 type ReferenceContext struct {
 	IncludeDeclaration bool `json:"includeDeclaration"`
+
+	// Sourcegraph extension
+	XLimit int `json:"xlimit,omitempty"`
 }
 
 type ReferenceParams struct {

Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,9 @@ type ParameterInformation struct {`
`156`	`156`
`157`	`157`	`type ReferenceContext struct {`
`158`	`158`	IncludeDeclaration bool `json:"includeDeclaration"`
	`159`	`+`
	`160`	`+ // Sourcegraph extension`
	`161`	+ XLimit int `json:"xlimit,omitempty"`
`159`	`162`	`}`
`160`	`163`
`161`	`164`	`type ReferenceParams struct {`