gocode: Replace usages of fmt.Print* with log.Print*

keegancsmith · keegancsmith · commit d0a69e92f6bd · 2018-09-09T21:02:22.000+04:00
We should never write to stdout, only stderr. Otherwise programs which use stdout/stdin communication will break. Ran the following from the gocode directory: codemod --extensions go fmt.P log.P goimports -w * Fixes sourcegraph#313
diff --git a/langserver/internal/gocode/decl.go b/langserver/internal/gocode/decl.go
@@ -937,7 +937,7 @@ func infer_type(v ast.Expr, scope *scope, index int) (ast.Expr, *scope, bool) {
 		return t, scope, true
 	default:
 		_ = reflect.TypeOf(v)
-		//fmt.Println(ty)
+		//log.Println(ty)
 	}
 	return nil, nil, false
 }
diff --git a/langserver/internal/gocode/utils.go b/langserver/internal/gocode/utils.go
@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"go/build"
 	"io/ioutil"
+	"log"
 	"os"
 	"path/filepath"
 	"runtime"
@@ -184,18 +185,18 @@ var g_backtrace_mutex sync.Mutex
 func print_backtrace(err interface{}) {
 	g_backtrace_mutex.Lock()
 	defer g_backtrace_mutex.Unlock()
-	fmt.Printf("panic: %v\n", err)
+	log.Printf("panic: %v\n", err)
 	i := 2
 	for {
 		pc, file, line, ok := runtime.Caller(i)
 		if !ok {
 			break
 		}
 		f := runtime.FuncForPC(pc)
-		fmt.Printf("%d(%s): %s:%d\n", i-1, f.Name(), file, line)
+		log.Printf("%d(%s): %s:%d\n", i-1, f.Name(), file, line)
 		i++
 	}
-	fmt.Println("")
+	log.Println("")
 }
 
 //-------------------------------------------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -937,7 +937,7 @@ func infer_type(v ast.Expr, scope scope, index int) (ast.Expr, scope, bool) {`
`937`	`937`	`return t, scope, true`
`938`	`938`	`default:`
`939`	`939`	`_ = reflect.TypeOf(v)`
`940`		`- //fmt.Println(ty)`
	`940`	`+ //log.Println(ty)`
`941`	`941`	`}`
`942`	`942`	`return nil, nil, false`
`943`	`943`	`}`