fix config

atulkum · atulkum · commit d3f1b6e771a1 · 2019-01-20T00:17:52.000-08:00
diff --git a/neural_ner/config.py b/neural_ner/config.py
@@ -53,8 +53,8 @@ class Config(object):
 
 config.is_l2_loss = False
 
-config.model_name = 'model.NER_SOFTMAX_CHAR'
-config.optimizer = 'sgd'
+config.model_name = 'model.NER_SOFTMAX_CHAR_CRF'
+config.optimizer = 'sgd_mom'
 
 config.use_pretrain_embd = True
 
diff --git a/neural_ner/model.py b/neural_ner/model.py
@@ -130,8 +130,8 @@ def forward(self, batch):
         return emissions
 
     def get_loss(self, logits, y, s_lens):
-        #loss = -1 * self.crf.log_likelihood(logits, y)
-        loss = self.crf.structural_perceptron_loss(logits, y)
+        loss = -1 * self.crf.log_likelihood(logits, y)
+        #loss = self.crf.structural_perceptron_loss(logits, y)
         loss = loss / s_lens.float()
         loss = loss.mean()
         if self.config.is_l2_loss:
diff --git a/neural_ner/model_utils.py b/neural_ner/model_utils.py
@@ -33,6 +33,8 @@ def get_optimizer(model, config):
     if config.optimizer == 'adam':
         optimizer = Adam(params, amsgrad=True)
     elif config.optimizer == 'sgd':
+        optimizer = SGD(params, lr=0.01)
+    elif config.optimizer == 'sgd_mom':
         optimizer = SGD(params, lr=0.01, momentum=0.9)
 
     num_params = sum(p.numel() for p in params)
