Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/crypto
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.19.0
Choose a base ref
...
head repository: golang/crypto
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.20.0
Choose a head ref
  • 5 commits
  • 11 files changed
  • 4 contributors

Commits on Feb 8, 2024

  1. x509roots/nss: manually exclude a confusingly constrained root

    Fixes golang/go#61963
    
    Change-Id: I16920d160af74772ef5aa650d1274e07c3ca9adc
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/562475
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker committed Feb 8, 2024
    1 Configuration menu
    Copy the full SHA
    62c9f17 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. ssh/test: don't use DSA keys in integrations tests, update test RSA key

    on RHEL 9 OpenSSH does not support DSA keys and RSA keys with size less
    than 2048 bits, furthermore signing with ssh-rsa (SHA-1 signatures) and
    ssh-dss is not allowed, therefore:
    
    1) replaced the 1024-bit RSA key used in the test with a new 2048-bit
       one
    2) removed DSA key from itegration tests
    3) allowed signature errors using ssh-rsa in agent integration tests, we
       also check SHA-2 variants that are not skipped
    
    Fixes golang/go#65581
    
    Change-Id: I54bf997b61ef4d91d38eb624275737ba7291bb20
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/562755
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Nicola Murino <nicola.murino@gmail.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    drakkan authored and gopherbot committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1c981e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. x/crypto/internal/poly1305: improve sum_ppc64le.s

    This contains a few minor improvements to sum_ppc64le.s
    which result in up to 10% performance improvement for
    some of the benchmarks in this directory.
    
    - ADDZE followed by ADD can be combined into ADDE
    - PCALIGN added to the loop
    - Eliminate a few unnecessary register moves
    
    goos: linux
    goarch: ppc64le
    pkg: golang.org/x/crypto/internal/poly1305
    cpu: POWER10
                     │ poly.orig.out │              poly.out              │
                     │    sec/op     │   sec/op     vs base               │
    64                   40.34n ± 0%   38.13n ± 0%   -5.47% (p=0.002 n=6)
    1K                   482.2n ± 0%   444.6n ± 0%   -7.81% (p=0.002 n=6)
    2M                   978.4µ ± 0%   879.3µ ± 0%  -10.12% (p=0.002 n=6)
    64Unaligned          40.35n ± 0%   38.16n ± 0%   -5.42% (p=0.002 n=6)
    1KUnaligned          482.0n ± 0%   444.2n ± 0%   -7.84% (p=0.002 n=6)
    2MUnaligned          978.4µ ± 0%   879.4µ ± 0%  -10.12% (p=0.002 n=6)
    Write64              32.69n ± 0%   30.71n ± 0%   -6.04% (p=0.002 n=6)
    Write1K              472.4n ± 0%   436.5n ± 0%   -7.60% (p=0.002 n=6)
    Write2M              978.3µ ± 0%   879.4µ ± 0%  -10.11% (p=0.002 n=6)
    Write64Unaligned     32.67n ± 0%   30.71n ± 0%   -6.00% (p=0.002 n=6)
    Write1KUnaligned     472.6n ± 0%   436.4n ± 0%   -7.66% (p=0.002 n=6)
    Write2MUnaligned     978.5µ ± 0%   879.6µ ± 0%  -10.10% (p=0.002 n=6)
    geomean              2.569µ        2.367µ        -7.87%
    
    Change-Id: I63314e7252ef10fb2d157f623c4bc2e31a63ae32
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/558775
    Reviewed-by: David Chase <drchase@google.com>
    Reviewed-by: Michael Knyszek <mknyszek@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Paul Murphy <murp@ibm.com>
    Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
    TryBot-Result: Gopher Robot <gobot@golang.org>
    Reviewed-by: Than McIntosh <thanm@google.com>
    laboger committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    1a86580 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2024

  1. ocsp: don't use iota for externally defined constants

    Style fix: iota shouldn't be used for values that come from RFCs or
    things that go over the wire or to disk.
    
    Change-Id: Ib903ec1bce7e71ff81094db3de8d0b71e16f52f3
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/564695
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    bradfitz authored and gopherbot committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    5bead59 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. all: update go.mod x/net dependency

    Not necessary for anything, but need to test something harmless.
    
    Change-Id: I4faa64ef2c8f1f14df5ccaa37836fc56beed4f50
    Reviewed-on: https://go-review.googlesource.com/c/crypto/+/566917
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    rolandshoemaker authored and gopherbot committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    0aab8d0 View commit details
    Browse the repository at this point in the history
Loading