Skip to content

go/types: TestFixedbugs/issue70549.go fails on linux-s390x-ibm builder #73206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Apr 7, 2025 · 4 comments
Closed

go/types: TestFixedbugs/issue70549.go fails on linux-s390x-ibm builder #73206

dmitshur opened this issue Apr 7, 2025 · 4 comments
Labels
arch-s390x Issues solely affecting the s390x architecture. BugReport Issues describing a possible bug in the Go implementation. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.25

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Apr 7, 2025 •
edited
Loading

The TestFixedbugs/issue70549.go test recently added in CL 662775 (for #70549) is consistently failing on linux-s390x-ibm and linux-s390x-ibm-race builders:

--- FAIL: TestFixedbugs (0.61s)
    --- FAIL: TestFixedbugs/issue70549.go (0.00s)
        check_test.go:281: ../../internal/types/testdata/fixedbugs/issue70549.go:12:11: no error expected: "undefined: math.sin (but have Sin)"
        check_test.go:319: --- p: unreported errors:
        check_test.go:323: ../../internal/types/testdata/fixedbugs/issue70549.go:12:11:  ERROR "name sin not exported by package math" 
        check_test.go:281: ../../internal/types/testdata/fixedbugs/issue70549.go:12:11: no error expected: "undefined: math.sin (but have Sin)"
        check_test.go:319: --- p: unreported errors:
        check_test.go:323: ../../internal/types/testdata/fixedbugs/issue70549.go:12:11:  ERROR "name sin not exported by package math" 
FAIL
FAIL	go/types	8.428s

(build log) (This wasn't caught by watchflakes because this builder hasn't been migrated to LUCI yet; that work is tracked in #67307.)

CC @golang/s390x, @mrkfrmn, @griesemer.
@dmitshur dmitshur added arch-s390x Issues solely affecting the s390x architecture. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Linux labels Apr 7, 2025
@gabyhelp
Copy link

gabyhelp commented Apr 7, 2025

Related Issues

Related Code Changes

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@gabyhelp gabyhelp added the BugReport Issues describing a possible bug in the Go implementation. label Apr 7, 2025
@mrkfrmn
Copy link
Contributor

mrkfrmn commented Apr 7, 2025

The error seems to indicate that the private function sin plainly does not exist on s390x, not that it's just unexported.

Looking at the math library, it does appear that there is some special handling for s390x (see sin_s390x.s and friends).

@mrkfrmn
Copy link
Contributor

mrkfrmn commented Apr 7, 2025

Perhaps this is a sign that we should not be altering error behavior based on unexported package internals.

Though, it does appear that we could simply move to a different function like Sqrt and friends.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/663635 mentions this issue: go/types, types2: fix failing error message test for s390x

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 7, 2025
@dmitshur dmitshur added this to the Go1.25 milestone Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-s390x Issues solely affecting the s390x architecture. BugReport Issues describing a possible bug in the Go implementation. NeedsFix The path to resolution is known, but the work has not been done. OS-Linux Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.25
Development

No branches or pull requests
4 participants
@dmitshur @gopherbot @gabyhelp @mrkfrmn